Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9453: Remove Espoo and Vantaa schools from comprehensive school search fallback #523

Merged
merged 1 commit into from
Dec 14, 2023
Merged

UHF-9453: Remove Espoo and Vantaa schools from comprehensive school search fallback #523

merged 1 commit into from
Dec 14, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Dec 13, 2023 •
edited by khalima
Loading

UHF-9453

What was done

  • Change comprehensive school search fallback view so that it lists only the schools that have Helsinki in their address

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9453
    • make fresh
  • Run make drush-cr

How to test

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

@teroelonen
UHF-9453: Change comprehensive school search fallback view so that it…
cff3f0c 
… lists only the schools that have Helsinki in their address
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

khalima
khalima approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚀

@teroelonen teroelonen merged commit cf02e52 into dev Dec 14, 2023
2 checks passed
@teroelonen teroelonen deleted the UHF-9453 branch December 14, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima