Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Fix district search ul>div #848

Merged
merged 2 commits into from
Dec 5, 2023
Merged

UHF-X Fix district search ul>div #848

merged 2 commits into from
Dec 5, 2023

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Dec 5, 2023 •
edited
Loading

UHF-X district search ul>div problem

district search is missing the li-tags here

What was done

  • li-element was added, the bullet point was removed and role="list" was added for safari compatibility

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_fix_district_search_ul
  • Run make drush-cr

How to test

  • Check that ul has li
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

@Arkkimaagi Arkkimaagi merged commit bc9bee0 into main Dec 5, 2023
1 check passed
@Arkkimaagi Arkkimaagi deleted the UHF-X_fix_district_search_ul branch December 5, 2023 12:11
This was referenced Dec 5, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jussiles Jussiles Jussiles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @Jussiles