Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-X accordion overflow fix #843

Merged
merged 2 commits into from
Nov 30, 2023
Merged

UHF-X accordion overflow fix #843

merged 2 commits into from
Nov 30, 2023

Conversation

Arkkimaagi
Copy link
Contributor

UHF-X

With the recent improvent to animate the accordions, a bug was introduced where accordions reserve space below footer when they're closed. This is especially visible on pages like Pasilan Peruskoulu that have long content inside accordions.

What was done

  • A weird fix was found where setting the hidden content to move with transform property by 0 units, the reserved space goes away in all tested browsers (safari, ff, chrome).

How to install

  • Make sure your (KASKO) instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-X_accordion_overflow_fix
  • Run make drush-cr

How to test

  • Open for example the Kasko instance Pasilan peruskoulu page. Check that you no longer can scroll past footer.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this! 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants