Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-8340: Updated remote video background color, text color and video title margins #1104

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Nov 6, 2024

UHF-8340

What was done

  • Changed remote video background from black to black-05
  • Changed text color to black
  • Changed margins between video and video title

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-8340
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-8340
  • Run make drush-updb drush-cr

How to test

  • Go to for example some basic page and add a remote video paragraph there, the colors should now be as described
  • Check that the video title field is now required
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

Copy link

github-actions bot commented Nov 6, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1104/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very nicely 🦖

Copy link

github-actions bot commented Nov 7, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/1104/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants