-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-10614: News article and news item publish date changes #1062
Conversation
|
templates/component/hero.twig
Outdated
{{ published_time }} | ||
</time> | ||
|
||
{% if updated_time|render|striptags|trim is not empty and html_updated_time|render|striptags|trim is not empty and updated_time > published_time %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use html_updated_time > html_published_time
for more consistent results, otherwise the updated datetime stays hidden in a lot of cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was actually a bigger bug here I think - it was printing and comparing the created and published_at dates when it should have actually done the comparison to changed and published_at values. This is now fixed.
@@ -49,6 +49,10 @@ $koro-height: 50px; | |||
} | |||
} | |||
|
|||
.hero__publish-information { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the unwanted spacing before the datetime on the template.
Risto re-checked this after Juho again.
UHF-10614
What was done
How to install
How to test
Continuous documentation
Translations
Other PRs