check for property access value of READ_WRITE on any platform #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swapnil Wagh <waghswapnil@gmail.com>
vvb
reviewed
Jan 24, 2017
| @@ -751,6 +752,18 @@ def validate_property_value(mo, prop, value): | |||
| return False | |||
|
|
|||
|
|
|||
| def validate_property_access(mo, prop, platform=None): | |||
There was a problem hiding this comment.
validate_property_access -> is_writable_prop
vvb
reviewed
Jan 24, 2017
| platform) | ||
| if prop_: | ||
| access_list.append(prop_.access) | ||
| return MoPropertyMeta.READ_WRITE in access_list |
There was a problem hiding this comment.
the list is not required.. just return True in the loop and false outside of it.
vvb
reviewed
Jan 24, 2017
| @@ -181,7 +181,7 @@ def __set_prop(self, name, value, mark_dirty=True, forced=False): | |||
| return | |||
| if not forced: | |||
| prop = imccoreutils.get_prop_meta(self, name) | |||
| if prop.access != imccoremeta.MoPropertyMeta.READ_WRITE: | |||
| if not imccoreutils.validate_property_access(self, name): | |||
vvb
requested changes
Jan 24, 2017
Signed-off-by: Swapnil Wagh <waghswapnil@gmail.com>
Signed-off-by: Swapnil Wagh <waghswapnil@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swapnil Wagh waghswapnil@gmail.com