make boot order api compatible with python3 using imcgenutils.iteritems #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all for python3 compatibility
|
I will update this PR to include the v2 version of boot.py as well since it is non-breaking between v1/v2 of the api |
… method call for python3 compatibility
|
See second commit. The codeclimate checks are failing because of the v1/v2 api copy that was done, not an issue with the code at runtime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am utilizing the py3 compatibility function "imcgenutils.iteritems". I only tested with python3, but I can't imagine it would do anything unseemly in python2 given the usage elsewhere in imcsdk.