Use CP_ACP over CP_OEMCP for output #1461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CP_ACP makes more sense than CP_OEMCP. It is more common that applications use ACP over OEM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP_ACP makes more sense than CP_OEMCP. It is more common that applications use ACP over OEM.
Tested by inputting a file with unicode characters in its name. Now it is presented in the ACP. Also ran
ctest -C RelWithDebInfobut I'm not sure if it tests those kinds of things.An alternative would be to encode it as UTF-8. Then all unicode characters could be represented.