-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Throwable/Error feature #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I think we can unpin #321 after this gets merged.
Should we extract all the removed code to a separate repo? (i.e. having a version of Chucker that works only for Throwable?)
Community feedback was that it would be useful so we might do that at some point. But I wouldn't rush it before 4.x
. Unless you just want to keep it in a repo for now so the code does not get lost.
I'm dismissing my approval because I just noticed that README.md requires update as well. :)
Looks good for me. I think that we should switch to just Talking about README - I returned to my suggestion of moving documentation to its own website/page and will present updated version for a feedback pretty soon. |
LGTM About the README, I like to have information of How to use the library in the root README. And not to have to search for it. |
Updated
Agree on doing this in a subsequent PR 👍
Well the code won't "never" get lost. We can still restore the repo just before this PR and dump it in a separate module/repository. Let's wait for after the 4.x release and see if the community is requesting it in any form.
+1 🚀
On this point, I agree on having the README as the entry point. However we fail to keep it up to date + it's getting longer and longer. I think we reached a point where having a proper project website would be beneficial (easier to search for information and easier to reference pages in Issue responses, etc.) |
0fa3184
to
7c4cda4
Compare
📄 Context
This is the outcome of the community poll we had in #321
📝 Changes
@Deprecated
method for such featureViewPager
/TabView
anymore5
📷 Screenshots
🚫 Breaking
Yes, as we're removing a lot of methods as planned (this will go in 4.x)
🛠️ How to test
Mostly removing code so not much to test.
⏱️ Next steps
Should we extract all the removed code to a separate repo? (i.e. having a version of Chucker that works only for Throwable?)