Add pre-commit hook and task to automatically install it #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nicola Corti <corti.nico@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
This PR implements enhancement #248 to run code checks before commiting the code. Except adding the hook itself I have also added a task to install hook which runs whenever clean task is fired. It means that with such hack every contributor will have hook installed automatically.
Closes #248
📝 Changes
pre-commitscript filecleantask to depend on install task.📎 Related PR
🚫 Breaking
Nothing
🛠️ How to test
Run
CleanorRebuildtask and see thatinstallGitHooktask is executed as well.After that hook should run on every commit attempt.
⏱️ Next steps
We might consider integrating formatting task into the hook as well after adding #249