Fix the CI setup for build on forks #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous commit I accidentally broke the CI builds coming from external forks. Forks don't have access to this ORG secrets so the publishToMavenLocal task was failing as the environment variables were blank. Moreover I'm also disabling the publishing workflow for forks.
vbuberen
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
With the previous commit I accidentally broke the
CI builds coming from external forks. See #159
Forks don't have access to this ORG secrets so
the publishToMavenLocal task was failing as the
environment variables were blank.
Moreover I'm also disabling the publishing workflow for forks.
🛠️ How to test
If the build is ✅ , let's merge and rebase #159 on top of this.