Payload processing refactoring #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierperez
reviewed
Aug 3, 2020
Comment on lines
+67
to
+69
| fun CharSequence.applyBoldSpan() = SpannableString(this).apply { | ||
| setSpan(StyleSpan(Typeface.BOLD), 0, this.length, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE) | ||
| } |
There was a problem hiding this comment.
Would it be ok to name it .bold()?
It could be called as "${headerItem.name}: ".bold().
|
|
||
| internal class TransactionHeadersAdapter : RecyclerView.Adapter<TransactionHeadersAdapter.HeaderViewHolder>() { | ||
|
|
||
| private val headers = arrayListOf<HttpHeader>() |
There was a problem hiding this comment.
Generaly speaking, I don't get why we should use arrayListOf instead of mutableListOf.
Comment on lines
+49
to
+51
| private val headerAdapter by lazy { TransactionHeadersAdapter() } | ||
| private val bodyAdapter by lazy { TransactionBodyAdapter() } | ||
| private val imageAdapter by lazy { TransactionImageAdapter() } |
There was a problem hiding this comment.
These 3 adapter are not yet called, is it normal?
There was a problem hiding this comment.
It is a draft PR, it is not finalized as well as not meant for review.
|
Looks like RecyclerView update isn't a priority for Google now, because 1.2.0 is still in alpha. Closing till we have a stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Context
ConcatAdapter seems like a very suitable component for Chucker and its payload RecyclerView. Having 3 separate adapters for each part of payload (headers, text body or image body) can help us to incorporate lots of improvements, like #324 or #195 much easier.
For example, we could get rid of having all headers formatted as a single String with HTML markup as it is done now (this code is already in PR) and use just raw names and values, which gives us more flexibility like being able to set spans however we need it.
I came to this idea after doing some work on search improvements for #195. Moreover, as we already discussed in some PRs as a side topic we need to move payload processing for output into a ViewModel.
My intention here is to have 3 lazily initialised adapters which we will add into parent only if there is a corresponding content (like add
ImageAdapteronly if there is an image in a payload).Also, I am going to switch to something similar to MVI approach to have states which view observes and renders (loading, data, empty).
This PR is in early preview, so no need for review. However, feedback is welcome.
I made it visible to everyone, since it might help some contributors to see where this part of the library is heading and to not produce too much conflicts.
📝 Changes
PayloadAdapterto be a newMergeAdapterto be continued...
📎 Related PR
Will add later