Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Kotlin Coroutines #270

Merged
merged 9 commits into from
Mar 24, 2020
Merged

Migrate to Kotlin Coroutines #270

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2396ac0
Add coroutine as a dependency in build.gradle
CuriousNikhil Mar 9, 2020
8ec798f
Migrate AsyncTasks to kotlin coroutines
CuriousNikhil Mar 9, 2020
1048d99
Migrate executors with the coroutines in repositories
CuriousNikhil Mar 9, 2020
6e8a313
Fix code style checks
CuriousNikhil Mar 13, 2020
0541295
Migrate executors with the coroutines in repositories
CuriousNikhil Mar 9, 2020
e4528b8
Migrate executors with the coroutines in repositories
CuriousNikhil Mar 9, 2020
7acecba
Migrate executors with the coroutines in repositories
CuriousNikhil Mar 9, 2020
6477806
Migrate executors with the coroutines in repositories
CuriousNikhil Mar 9, 2020
d050103
Migrate executors with the coroutines in repositories
CuriousNikhil Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions library/src/main/java/com/chuckerteam/chucker/internal/ui/MainViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,16 @@ import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.ViewModel
import androidx.lifecycle.switchMap
import androidx.lifecycle.viewModelScope
import com.chuckerteam.chucker.internal.data.entity.HttpTransactionTuple
import com.chuckerteam.chucker.internal.data.entity.RecordedThrowableTuple
import com.chuckerteam.chucker.internal.data.repository.RepositoryProvider
import com.chuckerteam.chucker.internal.support.NotificationHelper
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
import kotlinx.coroutines.launch
import kotlinx.coroutines.plus

internal class MainViewModel : ViewModel() {

private val currentFilter = MutableLiveData<String>("")
private val backgroundScope = CoroutineScope(Dispatchers.IO) + Job()

val transactions: LiveData<List<HttpTransactionTuple>> = currentFilter.switchMap { searchQuery ->
with(RepositoryProvider.transaction()) {
Expand All @@ -44,14 +40,14 @@ internal class MainViewModel : ViewModel() {
}

fun clearTransactions() {
backgroundScope.launch {
viewModelScope.launch {
RepositoryProvider.transaction().deleteAllTransactions()
}
NotificationHelper.clearBuffer()
}

fun clearThrowables() {
backgroundScope.launch {
viewModelScope.launch {
RepositoryProvider.throwable().deleteAllThrowables()
}
}
Expand Down
4 changes: 2 additions & 2 deletions ...c/main/java/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ import java.io.FileNotFoundException
import java.io.FileOutputStream
import java.io.IOException
import kotlinx.android.synthetic.main.chucker_fragment_transaction_payload.*
CuriousNikhil marked this conversation as resolved.
Show resolved Hide resolved
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
import kotlinx.coroutines.MainScope
import kotlinx.coroutines.cancel
import kotlinx.coroutines.launch
import kotlinx.coroutines.plus
Expand All @@ -51,7 +51,7 @@ internal class TransactionPayloadFragment :

private lateinit var viewModel: TransactionViewModel

private val uiScope = CoroutineScope(Dispatchers.Main) + Job()
private val uiScope = MainScope() + Job()
CuriousNikhil marked this conversation as resolved.
Show resolved Hide resolved

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Expand Down