Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding viewpager 2 for TransactionPagerAdapter #1099

Closed
wants to merge 1 commit into from

Conversation

kl3jvi
Copy link

@kl3jvi kl3jvi commented Sep 23, 2023

πŸ“· Screenshots

changed old viewpager with viewpager 2 for transaction activity

πŸ“„ Context

FragmentStatePagerAdapter is deprecated

πŸ“ Changes

πŸ“Ž Related PR

🚫 Breaking

πŸ› οΈ How to test

⏱️ Next steps

@kl3jvi kl3jvi requested a review from a team as a code owner September 23, 2023 18:32
@vbuberen
Copy link
Collaborator

vbuberen commented Sep 23, 2023

Thanks for your contribution, but we already had this change and decided to not merge it.
See #159
Since that time Google did literally nothing to fix their ViewPager2, so it makes no sense to migrate to it.

@kl3jvi kl3jvi closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants