Added 144p encoding #4492
Merged
Added 144p encoding #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
reviewed
Oct 26, 2021
Poslovitch
commented
Nov 3, 2021
|
I am having trouble with the remaining failing test. Could you please help me figure that out? :slight_smile: |
Implements Chocobozzz#4428
This reverts commit 266e114.
c2d303b to
79d4eca
Compare
|
Thanks a lot @Chocobozzz ! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As requested, I added the 144p encoding. I added corresponding config options, bitrate tests (the values might need some refining, and there are two
// FIXME- I could not find the values on the website provided), etc.Related issues
Implements #4428
Has this been tested?
Screenshots