Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the video channels limit (per user) server-wide configurable #4491

Conversation

Poslovitch
Copy link
Contributor

@Poslovitch Poslovitch commented Oct 24, 2021

Description

Per request in #3092, I have added a config option in the server config (video_channels.max_per_user) to allow server admins to choose how many video channels users are allowed to create. I have consequently added a field in the web config editor (screenshot 1). The default is kept at 20, and the value can go down to 1.
Despite now being configurable, it correctly prevents the user from creating any further channels if exceeding the amount (screenshot 2).

Related issues

Implements #3092

Has this been tested?

  • 👍 yes, I added tests to the test suite

Screenshots

image

image

Implements Chocobozzz#3092

Also added a "quota bar" in the account's settings page
Copy link
Owner

@Chocobozzz Chocobozzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also added a "quota progress bar" for video channels in the account's settings page (screenshot 3). It's something I believe is useful to make users aware of this limitation, but I have the feeling it might not be self-explanatory, and therefore confusing. Your thoughts?

I think we should not display this quota, that is just a server limitation. Most users won't reach this limit, so adding another quota bar in the profile est maybe "too much".

server/models/video/video-channel.ts Outdated Show resolved Hide resolved
server/middlewares/validators/videos/video-channels.ts Outdated Show resolved Hide resolved
@Poslovitch
Copy link
Contributor Author

I think we should not display this quota, that is just a server limitation. Most users won't reach this limit, so adding another quota bar in the profile est maybe "too much".

That's what I figured out for the users. What about the admins (displaying this quota in the users administration tab)?

@Chocobozzz
Copy link
Owner

What about the admins (displaying this quota in the users administration tab)?

I don't think it's worth the effort. As an admin, I don't think I'm interested in the number of channels per users. Other information like videos count/storage used by a user seems more useful.

@Poslovitch
Copy link
Contributor Author

I don't think it's worth the effort. As an admin, I don't think I'm interested in the number of channels per users.

Noted. I'll get rid of that.

@Poslovitch
Copy link
Contributor Author

Done. The original message has been edited to reflect the actual content of the PR.
I guess it should be ready to merge. Thanks for your input @Chocobozzz 👍

@Chocobozzz Chocobozzz merged commit 754b6f5 into Chocobozzz:develop Oct 26, 2021
@Chocobozzz
Copy link
Owner

Thanks @Poslovitch

@Poslovitch Poslovitch deleted the feature/3092-configurable-channels-limit branch October 26, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants