Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten hotkeys definitions #3702

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

kontrollanten
Copy link
Contributor

@kontrollanten kontrollanten commented Feb 5, 2021

Description

  • Stricten fullscreen hotkey to only be targeted when shift, ctrl, alt and meta key isn't pressed.
  • Stricten increase/decrease playback rate hotkey to only be targeted when shift, ctrl, alt and meta key isn't pressed.
  • Stricten frame by frame hotkey to only be targeted when ctrl, alt and meta key isn't pressed.
  • Remove VLC mimic when using arrow keys to instead popular video web apps.

Related issues

fixes #2810

Has this been tested?

  • 👍 yes, light tests as follows are enough
  1. Play a video and try hotkeys listen under Description.

@rigelk
Copy link
Collaborator

rigelk commented Feb 5, 2021

@kontrollanten in the future, please use reserved words to resolve related issues (i.e. fixes, resolves, etc.).

@kontrollanten
Copy link
Contributor Author

Didn't I do that? f964a85

@rigelk
Copy link
Collaborator

rigelk commented Feb 5, 2021

Sure, but that's not linking the PR on GitHub and its discussion. See your first post and my edit.

@Chocobozzz Chocobozzz requested a review from rigelk February 8, 2021 10:57
@rigelk rigelk self-assigned this Feb 9, 2021
@Chocobozzz Chocobozzz merged commit 684cdac into Chocobozzz:develop Feb 16, 2021
@kontrollanten kontrollanten deleted the tighten-hotkeys branch February 16, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ALT+Arrow keys override browser history control
3 participants