redirect to login on 401, display 403 variant #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobozzz
requested changes
Jan 25, 2021
9bedf75 to
2cea393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outside of components using
LoginGuard, we can detect which objects require to be logged in based on their return code, whichAuthInterceptorcan help us redirect. This is especially useful for internal videos, as mentioned in https://framacolibri.org/t/avoir-le-bouton-de-login-sur-lerreur-404/10761.Has this been tested?
This is done client-side only, relying on existing server codes, so no tests were added to the CI harness. However, I tested manually for internal, private and blocked videos.
Screenshots