-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pixel size to tooltip and gif support with FFmpeg for avatar upload #3329
Add pixel size to tooltip and gif support with FFmpeg for avatar upload #3329
Conversation
I'm sorry but we can't just copy unknown files from users, without resize or compression |
@Chocobozzz I didn't make it to compress and resize gif with Jimp, would you help ? |
@kimsible you might need a plugin for Jimp to bring it support of gifs, like https://github.com/jtlapp/gifwrap |
@rigelk thanks, you mean with need a new filter / action server side to handle it ? also how can we filter the extensions list constant ? Edit : Don't hesitate to propose changes to include filters server side |
ffmpeg might me able to resize a gif |
Thanks @Chocobozzz @rigelk for the tips, it now uses FFmpeg to process GIF :
Cons :
|
1ea77eb
to
8ce3253
Compare
Please next time add unit tests. |
Description
Related issues
Gif support only : #3299
Has this been tested?
- [ ] 👍 yes, I added tests to the test suiteDidn't found any unit test for Image processingI just live tested, does it need unit test @Chocobozzz ?
Screenshots