Fix vF in 8xy4/5/6/7/E, Fix F key not being read #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated makefile, changed the name of the "index" variable to "cindex" to fix compiling error
Have vF be set after the operation in 8xy4, 8xy5, and 8xy7
Key F is now correctly polled for
|
Really cool to see contributions to this project. Sorry, for some reason your Discord message didn't show in the side bar and I didn't see it until recently. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly fixes some bugs with how vF is set in the 8XYx ops, having it be set after the operation with the flag being set before the operation. It also changes a variable name ("index" to "cindex") and the makefile in order to get this to compile on the latest toolchain (V10.2 at the time of writing), and fixes an off-by-one error during key polling that prevented the key for "F" from ever being read.