Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how you think you can improve the project #2

Open
atherdon opened this issue May 8, 2018 · 8 comments
Open

how you think you can improve the project #2

atherdon opened this issue May 8, 2018 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@atherdon
Copy link
Contributor

atherdon commented May 8, 2018

You tell me that you moved forward with react knowledge, so i assume there a lot of places - that you want to change/delete/update.

Check your code and list here at least 4-5 improvements that you want to do.

@atherdon atherdon added the enhancement New feature or request label May 8, 2018
@mackmmiller
Copy link
Contributor

mackmmiller commented May 8, 2018

  • Break code into multiple files
  • Replace SCSS & Bootstrap with Styled Components
  • Implement modals via React Portal API
  • AddRecipeModal & EditRecipeModal may be able to reduced to a single component and handle props better
  • Replace component methods with arrow functions

@atherdon
Copy link
Contributor Author

atherdon commented May 8, 2018

ok, i like it. push code here - i want to compare that list with code at components

@mackmmiller
Copy link
Contributor

@atherdon, do you have a sense of the style or design direction for this project? I can reuse the styles I had before, but it's pretty ugly.

@atherdon
Copy link
Contributor Author

atherdon commented May 9, 2018

styles are not in my top-priorities, but i'll create a separated task and we'll discuss it in details

@atherdon
Copy link
Contributor Author

@mackmmiller tell me if you still interested to move forward this project

@atherdon
Copy link
Contributor Author

@mackmmiller i'm continue to plan this project, working on documentation right now

@mackmmiller
Copy link
Contributor

@atherdon, apologies I started a new job and have been busy getting situated. Things have settled down and I'll be able to put in time more consistently now.

@atherdon
Copy link
Contributor Author

@mackmmiller Don't worry, there is no rush. if you need time - i'm ok with it. Btw, we're moving this project forward! Soon i'll finish a documentation - hope it'll make our work more clear and simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants