Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't publish to test pypi #96

Merged
merged 1 commit into from
Nov 10, 2022
Merged

don't publish to test pypi #96

merged 1 commit into from
Nov 10, 2022

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 9, 2022

No description provided.

@arvidn arvidn mentioned this pull request Nov 9, 2022
Merged
@arvidn arvidn requested review from richardkiss and aqk November 9, 2022 10:48
altendky
altendky approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate to see these go, but since we haven't fixed the issues around them...

@altendky
Copy link
Contributor

Though this could just go to main directly?

@arvidn
Copy link
Contributor Author

arvidn commented Nov 10, 2022

my main motivation for this is to get #95 green

@altendky
Copy link
Contributor

Putting this in main and closing/reopening #95, or a rebase or catch up merge, will do that as well while retaining granular PRs to main. But, there is an approval here and one isn't even needed for Adam to merge this into their branch.

@aqk aqk merged commit bc23479 into ak.typecheck Nov 10, 2022
@aqk aqk deleted the remove-test-pypi branch November 10, 2022 20:30
@altendky
Copy link
Contributor

Mm, also, the granular path would have avoided dismissing the approving review on #95 and we wouldn't have waited for Adam to decide they want this in their branch. :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky approved these changes

@richardkiss richardkiss Awaiting requested review from richardkiss

@aqk aqk Awaiting requested review from aqk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @altendky @aqk