Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLS pairing raise on failure #290

Merged
merged 1 commit into from
May 24, 2023
Merged

BLS pairing raise on failure #290

merged 1 commit into from
May 24, 2023

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 23, 2023

These are some of the important points:

  • any operand in clvm is evaluated eagerly, so operations like these can easily be combined using any of multi-arg operator. But perhaps the most convenient would be the function proposed for the standard library (filtermap (bls_verify ...) (list conditions...))
  • raising on failure eliminates a class of errors (it's debatable how important it is though)
  • raising on failure guides people towards setting up their puzzles and solutions such that you always know that a verification will pass, or avoid running it at all, which I believe is best practice.
  • raising on failure (and returning nil) is compatible with unknown operators, and allows future verification operators to follow the same pattern and be soft-forked in outside of the softfork-guard. secp256 is a likely future candidate.

@arvidn arvidn force-pushed the bls-pairing-raise branch from f80c4f5 to 97c2a42 Compare May 23, 2023 10:12
@coveralls-official
Copy link

coveralls-official bot commented May 23, 2023

Pull Request Test Coverage Report for Build 5072478901

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 91.82%

Totals Coverage Status
Change from base Build 5071900008: 0.007%
Covered Lines: 4142
Relevant Lines: 4511

💛 - Coveralls

@arvidn arvidn force-pushed the bls-pairing-raise branch from 97c2a42 to 3820fa2 Compare May 24, 2023 17:58
@arvidn arvidn marked this pull request as ready for review May 24, 2023 18:01
@arvidn arvidn force-pushed the bls-pairing-raise branch from 3820fa2 to ebbf366 Compare May 24, 2023 18:12
@arvidn arvidn closed this May 24, 2023
@arvidn arvidn reopened this May 24, 2023
@arvidn arvidn merged commit 1bf6f09 into main May 24, 2023
@arvidn arvidn deleted the bls-pairing-raise branch May 24, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants