Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for the task queue buildup #8315

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Bugfix for the task queue buildup #8315

merged 2 commits into from
Sep 7, 2021

Conversation

Yostra
Copy link
Contributor

@Yostra Yostra commented Sep 3, 2021

No description provided.

@emlowe emlowe mentioned this pull request Sep 3, 2021
Closed
fchirica
fchirica approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@fchirica fchirica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking not to disconnect when we get an exception on new_compact_vdf (but instead, just log.error it). that said, it was working like this before, so perhaps we should just keep it in mind for the future.

@wjblanke wjblanke merged commit c353048 into main Sep 7, 2021
@wjblanke wjblanke deleted the efficent_compact branch September 7, 2021 21:01
cmmarslender pushed a commit that referenced this pull request Sep 8, 2021
@Yostra @cmmarslender
Bugfix for the task queue buildup (#8315)
8538756 
* fix bug

* remove except
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altendky altendky altendky left review comments

@arvidn arvidn arvidn left review comments

@emlowe emlowe emlowe left review comments

@fchirica fchirica fchirica approved these changes

@mariano54 mariano54 Awaiting requested review from mariano54

@almogdepaz almogdepaz Awaiting requested review from almogdepaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yostra @altendky @arvidn @fchirica @emlowe @wjblanke