Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some comments #19293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some comments #19293

wants to merge 1 commit into from
+1 −1

Conversation

racerole
Copy link

Purpose:

fix some comments

Current Behavior:

New Behavior:

Testing Notes:

@racerole racerole requested a review from a team as a code owner February 19, 2025 15:14
@racerole
Copy link
Author

Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits.

I have signed.

hoffmang9
hoffmang9 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@racerole
chore: fix comment
b155394 
Signed-off-by: racerole <jiangyifeng@outlook.com>
@racerole
Copy link
Author

Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits.

Sorry for my mistake.

Signed.

@racerole
Copy link
Author

lgtm

Thanks for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@racerole @hoffmang9 @ChiaAutomation