Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-885] Send different uncompact buckets to blueboxes. #18263

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Jul 1, 2024

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@fchirica fchirica added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jul 1, 2024
@fchirica fchirica removed the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jul 1, 2024
Copy link

coveralls-official bot commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9747773115

Details

  • 21 of 23 (91.3%) changed or added relevant lines in 1 file are covered.
  • 53 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.977%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/full_node/full_node.py 21 23 91.3%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/daemon/keychain_proxy.py 1 72.57%
chia/farmer/farmer.py 1 72.23%
chia/daemon/server.py 1 83.22%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 97.1%
chia/server/node_discovery.py 2 80.67%
chia/daemon/client.py 2 73.33%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.02%
chia/rpc/rpc_server.py 3 88.04%
chia/full_node/full_node.py 4 86.19%
Totals Coverage Status
Change from base Build 9719381064: -0.02%
Covered Lines: 101672
Relevant Lines: 111711

💛 - Coveralls

@fchirica fchirica changed the title Send different uncompact buckets to blueboxes. [CHIA-885] Send different uncompact buckets to blueboxes. Jul 3, 2024
@fchirica fchirica marked this pull request as ready for review July 3, 2024 00:49
@fchirica fchirica requested a review from a team as a code owner July 3, 2024 00:49
@emlowe emlowe linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jul 3, 2024

File Coverage Missing Lines
chia/full_node/full_node.py 84.6% lines 2802-2804, 2889
Total Missing Coverage
26 lines 4 lines 84%

Copy link

coveralls-official bot commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9770081235

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 26 (84.62%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.002%) to 90.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/full_node/full_node.py 22 26 84.62%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/wallet/wallet_node.py 1 88.72%
chia/daemon/client.py 1 73.94%
chia/daemon/server.py 1 83.22%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 97.1%
chia/rpc/rpc_server.py 3 87.71%
chia/_tests/core/util/test_lockfile.py 3 90.28%
chia/server/node_discovery.py 3 79.79%
chia/full_node/full_node.py 10 85.8%
Totals Coverage Status
Change from base Build 9719381064: -0.002%
Covered Lines: 101690
Relevant Lines: 111714

💛 - Coveralls

Copy link
Contributor

@emlowe emlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - with coverage exemption

@Starttoaster Starttoaster merged commit e6dbaef into main Jul 5, 2024
370 of 371 checks passed
@Starttoaster Starttoaster deleted the fc.chunk_uncompact branch July 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Bluebox disseminating same block to compact to multiple machines
3 participants