Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-508] Add tx_config and extra_conditions to DID creation endpoint #18024

Merged
merged 3 commits into from
May 18, 2024
Merged

[CHIA-508] Add tx_config and extra_conditions to DID creation endpoint #18024

merged 3 commits into from
May 18, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented May 15, 2024 •
edited
Loading

Missed in the initial refactors due to its unique position as a wallet creator, this PR adds the standard transaction parameters of tx_config and extra_conditions to the endpoint for creating DIDs.

Addresses #17997

@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label May 15, 2024
@Quexington Quexington changed the title Add tx_config and extra_conditions to DID creation endpoint [CHIA-508] Add tx_config and extra_conditions to DID creation endpoint May 15, 2024
@Quexington Quexington marked this pull request as ready for review May 15, 2024 20:21
@Quexington Quexington requested a review from a team as a code owner May 15, 2024 20:21
@Quexington Quexington requested a review from geoffwalmsley May 16, 2024 19:34
wjblanke
wjblanke approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@cmmarslender cmmarslender merged commit 1ae00f6 into main May 18, 2024
359 checks passed
@cmmarslender cmmarslender deleted the quex.add_tx_config_to_did_mint branch May 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@geoffwalmsley geoffwalmsley geoffwalmsley approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quexington @wjblanke @geoffwalmsley @cmmarslender