Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHIA-423] Port chia wallet send to @tx_out_cmd #18002

Merged
merged 1 commit into from
May 15, 2024
Merged

[CHIA-423] Port chia wallet send to @tx_out_cmd #18002

merged 1 commit into from
May 15, 2024

Conversation

Quexington
Copy link
Contributor

This adds the new @tx_out_cmd decorator to the chia wallet send command. This allows the command to output a transaction file instead of pushing the transaction automatically.

@Quexington Quexington added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label May 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

File Coverage Missing Lines
chia/cmds/wallet_funcs.py 64.3% lines 288, 291, 294, 300, 343
Total Missing Coverage
27 lines 5 lines 81%

@Quexington Quexington marked this pull request as ready for review May 14, 2024 15:42
@Quexington Quexington requested a review from a team as a code owner May 14, 2024 15:42
@Quexington Quexington changed the title Port chia wallet send to @tx_out_cmd [CHIA-423] Port chia wallet send to @tx_out_cmd May 14, 2024
@emlowe
Copy link
Contributor

emlowe commented May 14, 2024

Coverage exemption for error cases is ok.

@Quexington Quexington merged commit 96dd9e4 into long_lived/vault May 15, 2024
360 of 362 checks passed
@Quexington Quexington deleted the quex.port_chia_wallet_send_to_tx_out branch May 15, 2024 14:09
@Quexington Quexington mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffwalmsley geoffwalmsley geoffwalmsley approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quexington @emlowe @geoffwalmsley