Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump timeout for publishing macOS installers to avoid timeout #17960

Merged
merged 1 commit into from
May 3, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 3, 2024

Purpose:

this workflow times out quite frequently, e.g.

https://github.com/Chia-Network/chia-blockchain/actions/runs/8935001240/job/24543564631?pr=17951

Current Behavior:

timeout is 5 inutes

New Behavior:

timeout is 10 minutes

@arvidn arvidn added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes labels May 3, 2024
@arvidn arvidn marked this pull request as ready for review May 3, 2024 10:17
@arvidn arvidn requested a review from a team as a code owner May 3, 2024 10:17
@arvidn arvidn requested a review from altendky May 3, 2024 10:17
Copy link

Pull Request Test Coverage Report for Build 8936283626

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.01%) to 90.676%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 64.98%
chia/harvester/harvester_api.py 1 73.02%
chia/rpc/rpc_server.py 1 87.67%
chia/farmer/farmer.py 1 72.56%
chia/wallet/wallet_node.py 1 88.68%
chia/server/node_discovery.py 1 80.5%
chia/daemon/client.py 1 73.33%
chia/data_layer/data_layer.py 2 85.14%
chia/full_node/full_node.py 4 85.25%
chia/_tests/core/util/test_lockfile.py 22 77.73%
Totals Coverage Status
Change from base Build 8931619722: -0.01%
Covered Lines: 97995
Relevant Lines: 108015

💛 - Coveralls

Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some underlying unexpected network issues here, in general. Hopefully #17964 will avoid them entirely, longer term.

@pmaslana pmaslana merged commit a25dece into main May 3, 2024
358 of 359 checks passed
@pmaslana pmaslana deleted the bump-publish-timeout branch May 3, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants