Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run core util tests sequential #17871

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Apr 16, 2024

Purpose:

These tests appear to be failing consistently on python 3.12 when run in parallel.

Current Behavior:

core.util tests run in parallel

New Behavior:

core.util tests run sequentially

Testing Notes:

Example of failure: https://github.com/Chia-Network/chia-blockchain/actions/runs/8673266545/job/23849589076?pr=17857

@arvidn arvidn added the CI CI changes label Apr 16, 2024
@arvidn arvidn requested review from emlowe and ChiaMineJP April 16, 2024 07:16
@arvidn arvidn added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Apr 16, 2024
@arvidn arvidn marked this pull request as ready for review April 16, 2024 07:29
@arvidn arvidn requested a review from a team as a code owner April 16, 2024 07:30
Copy link
Contributor

File Coverage Missing Lines
chia/_tests/core/util/config.py 0.0% lines 4
Total Missing Coverage
Unknown Unknown 0%

@altendky
Copy link
Contributor

altendky commented Apr 16, 2024

Coverage complaint to be addressed (ignored) by #17873.

@emlowe
Copy link
Contributor

emlowe commented Apr 16, 2024

Coverage error is false positive as noted

@pmaslana pmaslana merged commit 8b6f761 into release/2.3.0 Apr 16, 2024
772 of 775 checks passed
@pmaslana pmaslana deleted the run-core-util-sequential branch April 16, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI changes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants