Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a couple of DAOWallet methods return lists of transaction records #17853

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Make a couple of DAOWallet methods return lists of transaction records #17853

merged 1 commit into from
Apr 15, 2024

Conversation

Quexington
Copy link
Contributor

This is better conformity with the standard API we expect from a method that generates transactions.

@Quexington Quexington marked this pull request as ready for review April 10, 2024 15:26
@Quexington Quexington requested a review from a team as a code owner April 10, 2024 15:26
@Quexington Quexington added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Apr 10, 2024
@Quexington Quexington closed this Apr 15, 2024
@Quexington Quexington reopened this Apr 15, 2024
@pmaslana pmaslana merged commit 831cb9b into main Apr 15, 2024
694 of 695 checks passed
@pmaslana pmaslana deleted the quex.dao_funcs_list_txs branch April 15, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffwalmsley geoffwalmsley geoffwalmsley approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quexington @geoffwalmsley @emlowe @pmaslana