make junit collection optional and disable for now #17828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
previously approved these changes
Apr 4, 2024
emlowe
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Between the JUnit and coverage artifacts we seem to be exceeding 1000 artifacts for the test workflow. There seems to be a limit here as the upload steps upload but the download step finds exactly 1000 artifacts and downloads exactly 1000 artifacts between the JUnit and coverage groups. This does not appear to be documented at https://github.com/actions/upload-artifact#limitations, only the 500 artifact limit per job.
Current Behavior:
New Behavior:
Testing Notes: