Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-435] Add chia wallet signer commands #17399

Merged
merged 24 commits into from
Jun 11, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jan 24, 2024

This PR caps off a thread of work that supports external signers for transactions generated by the wallet. With these commands, it should be possible to run two wallets with different security qualities and transport transactions back and forth between them for the colder one to sign. It currently uses binary files/QR codes to accomplish this although other methods of transport are certainly on the table.

@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2024
@Quexington Quexington changed the base branch from main to quex.transport_layer January 24, 2024 20:15
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 24, 2024
@Quexington Quexington closed this Jan 24, 2024
@Quexington Quexington reopened this Jan 24, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 24, 2024
@Quexington Quexington added Added Required label for PR that categorizes merge commit message as "Added" for changelog PR labels Jan 24, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 24, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 24, 2024
@Quexington Quexington force-pushed the quex.signer_commands branch from fb7a0c0 to 7add91b Compare January 29, 2024 15:51
@Quexington Quexington removed the PR label Jan 29, 2024
@Quexington Quexington added VC vault and removed VC labels Jan 31, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Mar 20, 2024
@github-actions github-actions bot added merge_conflict Branch has conflicts that prevent merge to main and removed coverage-diff labels Mar 20, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Mar 25, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Mar 25, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Mar 25, 2024
@Quexington Quexington changed the title Add chia wallet signer commands [CHIA-435] Add chia wallet signer commands May 14, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label May 23, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 23, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label May 23, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot May 23, 2024
Base automatically changed from quex.transport_layer to long_lived/vault June 5, 2024 19:12
@Quexington Quexington closed this Jun 5, 2024
@Quexington Quexington reopened this Jun 5, 2024
@Quexington Quexington marked this pull request as ready for review June 5, 2024 19:13
@Quexington Quexington requested a review from a team as a code owner June 5, 2024 19:13
Copy link
Contributor

github-actions bot commented Jun 5, 2024

File Coverage Missing Lines
chia/wallet/wallet_state_manager.py 75.0% lines 400, 402
Total Missing Coverage
303 lines 2 lines 99%

Copy link

coveralls-official bot commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9389919648

Details

  • 299 of 301 (99.34%) changed or added relevant lines in 6 files are covered.
  • 17 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.945%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/wallet/wallet_state_manager.py 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
chia/server/node_discovery.py 1 79.96%
chia/daemon/client.py 1 73.94%
chia/daemon/server.py 1 83.24%
chia/full_node/full_node_api.py 2 81.0%
chia/_tests/core/util/test_lockfile.py 2 90.28%
chia/rpc/rpc_server.py 3 88.04%
chia/wallet/wallet_node.py 7 88.25%
Totals Coverage Status
Change from base Build 9389912469: 0.02%
Covered Lines: 100691
Relevant Lines: 110666

💛 - Coveralls

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington merged commit 18d46ed into long_lived/vault Jun 11, 2024
708 of 714 checks passed
@Quexington Quexington deleted the quex.signer_commands branch June 11, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog coverage-diff vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants