-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert wallet RPC client to deserialized types #17393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
628c9ca
to
297115d
Compare
…2b75dfd64d7c1a30e4c7' into quex.wallet_rpc_client_types
Base automatically changed from
catchup/long_lived_vault_from_main_4df4496f57423173acd62b75dfd64d7c1a30e4c7
to
long_lived/vault
March 26, 2024 17:32
d00652f
to
9ba9060
Compare
AmineKhaldi
approved these changes
Apr 4, 2024
Pull Request Test Coverage Report for Build 8554640050Details
💛 - Coveralls |
wjblanke
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
Exclude_Notes
Use this label if the changes in the PR should be excluded from the release notes
vault
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the return values of the wallet RPC client into the marshal-able types introduced in #17201 . Previously, the client was very ad-hoc in what it returned: sometimes dictionaries, sometimes a specific part of the response deserialized, sometimes nothing. The purpose of standardizing like this is so that the whole of each RPC response is available when you call an RPC from the python client. This is important for upcoming PRs which take advantage of the output transactions that every tx_endpoint now returns.