Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert wallet RPC client to deserialized types #17393

Merged
merged 16 commits into from
Apr 8, 2024

Conversation

Quexington
Copy link
Contributor

@Quexington Quexington commented Jan 24, 2024

This PR converts the return values of the wallet RPC client into the marshal-able types introduced in #17201 . Previously, the client was very ad-hoc in what it returned: sometimes dictionaries, sometimes a specific part of the response deserialized, sometimes nothing. The purpose of standardizing like this is so that the whole of each RPC response is available when you call an RPC from the python client. This is important for upcoming PRs which take advantage of the output transactions that every tx_endpoint now returns.

@Quexington Quexington added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jan 24, 2024
@Quexington Quexington force-pushed the quex.wallet_rpc_client_types branch from 628c9ca to 297115d Compare January 24, 2024 16:42
@Quexington Quexington added the PR label Jan 24, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 29, 2024
@Quexington Quexington removed the PR label Jan 29, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 30, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jan 30, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jan 30, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 30, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 30, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Jan 31, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Feb 27, 2024
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Feb 27, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Feb 27, 2024
@Chia-Network Chia-Network deleted a comment from github-actions bot Feb 27, 2024
Base automatically changed from quex.observer_mode to long_lived/vault March 21, 2024 21:17
@Quexington Quexington changed the base branch from long_lived/vault to catchup/long_lived_vault_from_main_4df4496f57423173acd62b75dfd64d7c1a30e4c7 March 22, 2024 19:51
…2b75dfd64d7c1a30e4c7' into quex.wallet_rpc_client_types
Base automatically changed from catchup/long_lived_vault_from_main_4df4496f57423173acd62b75dfd64d7c1a30e4c7 to long_lived/vault March 26, 2024 17:32
@Quexington Quexington marked this pull request as ready for review March 26, 2024 17:34
@Quexington Quexington requested a review from a team as a code owner March 26, 2024 17:34
@Quexington Quexington closed this Mar 26, 2024
@Quexington Quexington reopened this Mar 26, 2024
@Quexington Quexington force-pushed the quex.wallet_rpc_client_types branch from d00652f to 9ba9060 Compare March 28, 2024 14:51
@Quexington Quexington marked this pull request as draft March 28, 2024 18:10
@Quexington Quexington marked this pull request as ready for review March 29, 2024 21:14
@Quexington Quexington requested a review from AmineKhaldi April 2, 2024 16:39
@AmineKhaldi AmineKhaldi closed this Apr 4, 2024
@AmineKhaldi AmineKhaldi reopened this Apr 4, 2024
Copy link

Pull Request Test Coverage Report for Build 8554640050

Details

  • 435 of 435 (100.0%) changed or added relevant lines in 22 files are covered.
  • 28 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.987%

Files with Coverage Reduction New Missed Lines %
chia/wallet/wallet_node.py 1 88.69%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 97.1%
chia/plotters/madmax.py 3 49.4%
chia/rpc/rpc_server.py 4 87.67%
chia/introducer/introducer.py 5 79.35%
chia/cmds/wallet_funcs.py 14 79.47%
Totals Coverage Status
Change from base Build 8511353407: 0.03%
Covered Lines: 98809
Relevant Lines: 108571

💛 - Coveralls

Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@Quexington Quexington closed this Apr 8, 2024
@Quexington Quexington reopened this Apr 8, 2024
@Quexington Quexington merged commit ec6957f into long_lived/vault Apr 8, 2024
851 checks passed
@Quexington Quexington deleted the quex.wallet_rpc_client_types branch April 8, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes vault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants