Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New aggregate signature conditions #15769

Merged
merged 12 commits into from
Jul 20, 2023
Merged

New aggregate signature conditions #15769

merged 12 commits into from
Jul 20, 2023

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Jul 14, 2023
@AmineKhaldi AmineKhaldi self-assigned this Jul 14, 2023
arvidn
arvidn reviewed Jul 14, 2023
View reviewed changes
chia/consensus/default_constants.py Outdated Show resolved Hide resolved
chia/simulator/wallet_tools.py Outdated Show resolved Hide resolved
chia/util/initial-config.yaml Outdated Show resolved Hide resolved
chia/util/condition_tools.py Outdated Show resolved Hide resolved
tests/clvm/test_puzzles.py Outdated Show resolved Hide resolved
chia/util/condition_tools.py Outdated Show resolved Hide resolved
chia/util/condition_tools.py Outdated Show resolved Hide resolved
tests/util/test_condition_tools.py Show resolved Hide resolved
@coveralls-official
Copy link

coveralls-official bot commented Jul 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5555391202

  • 204 of 224 (91.07%) changed or added relevant lines in 17 files are covered.
  • 80 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.08%) to 87.364%
Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/simulator/block_tools.py 1 2 50.0%
chia/util/condition_tools.py 50 51 98.04%
chia/simulator/wallet_tools.py 6 24 25.0%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 77.22%
chia/wallet/wallet_node.py 1 86.66%
chia/server/node_discovery.py 2 77.99%
chia/wallet/wallet_state_manager.py 2 95.3%
chia/data_layer/data_store.py 10 91.64%
chia/data_layer/download_data.py 12 54.94%
chia/data_layer/data_layer.py 52 63.21%
Totals Coverage Status
Change from base Build 5551480313: -0.08%
Covered Lines: 80262
Relevant Lines: 91750
💛 - Coveralls

@AmineKhaldi AmineKhaldi reopened this Jul 14, 2023
@arvidn arvidn requested a review from richardkiss July 14, 2023 19:18
@AmineKhaldi AmineKhaldi marked this pull request as ready for review July 14, 2023 20:41
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner July 14, 2023 20:41
@AmineKhaldi AmineKhaldi requested a review from arvidn July 14, 2023 20:41
@arvidn
Copy link
Contributor

arvidn commented Jul 14, 2023

lgtm

@arvidn

This comment was marked as outdated.

Sign in to view
@arvidn
Copy link
Contributor

arvidn commented Jul 15, 2023

I think this is a good addition to this PR: AmineKhaldi#3

arvidn
arvidn previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good if @richardkiss or @bramcohen would take a look at this as well, as it's a sensitive patch

@wallentx
Copy link
Contributor

Holding on merge until one of the above mentioned approve

@wallentx wallentx requested a review from bramcohen July 17, 2023 17:00
richardkiss
richardkiss previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@richardkiss richardkiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple more annoying suggestions, but they're totally optional.

@AmineKhaldi AmineKhaldi requested a review from richardkiss July 19, 2023 16:16
@wallentx wallentx requested a review from a team July 20, 2023 20:04
@wallentx wallentx merged commit de05016 into Chia-Network:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paninaro paninaro paninaro approved these changes

@richardkiss richardkiss richardkiss approved these changes

@arvidn arvidn arvidn left review comments

@bramcohen bramcohen Awaiting requested review from bramcohen

Assignees

@AmineKhaldi AmineKhaldi

Labels
Added Required label for PR that categorizes merge commit message as "Added" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AmineKhaldi @arvidn @wallentx @richardkiss @paninaro