Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry handlers #120

Closed
cheh opened this issue Nov 4, 2016 · 1 comment
Closed

Cherry handlers #120

cheh opened this issue Nov 4, 2016 · 1 comment
Labels
enhancement

Comments

@cheh
Copy link
Member

cheh commented Nov 4, 2016

Unnecessary check because above $this->settings['action'] is checking for empty condition:

https://github.com/CherryFramework/cherry-framework/blob/master/modules/cherry-handler/cherry-handler.php#L87
MakhonkoDenis pushed a commit that referenced this issue Nov 9, 2016
FIX: issues #120 #116 #115
4ddf95c
@MakhonkoDenis
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cheh @MakhonkoDenis