Fix folder title treatment #570
Merged
+97
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug #569
and also, so far not detected (introduced in 4.3.0 during rewrite), new bug that parameter folder
title(aliasname) is "ignored" entirely.Extend check to test the mentioned behavior.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
#569
parameter
namealiased bytitleis entirely ignored.What is the new behavior?
in check mod, the returned change status is set to True if the changes would have taken place in normal mode.
Other information