Use safe_eval instead of temporary rules for comparison #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks promising! |
robin-checkmk
pushed a commit
that referenced
this pull request
May 22, 2023
Use safe_eval instead of temporary rules for comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #233 we create temporary rules as a means to get the exact API representation for the value_raw.
Ansible's module_utils library provides a "safe_eval()" implementation of ast.literal_eval(). As it was suggested by a developer in #153 we could use this technique to evaluate the values as Python objects before the comparison, as other modules and checkmk api does.
This removes the need to create a temporary rule.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Create temp rule
Fill the logs
Slow
Issue Number: #153 #186
What is the new behavior?
Use safe_eval from ansible module_utils
Does not fill the logs
Faster