Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨feat, 🎨design: 차트 μ»΄ν¬λ„ŒνŠΈ 생성(일반 차트, 주식 차트 λ“±) #63

Merged
merged 2 commits into from
Jun 21, 2024
Merged

✨feat, 🎨design: 차트 μ»΄ν¬λ„ŒνŠΈ 생성(일반 차트, 주식 차트 λ“±) #63

merged 2 commits into from
Jun 21, 2024

Conversation

donginLee
Copy link
Contributor

@donginLee donginLee commented Jun 21, 2024 •
edited by gariguri
Loading

#️⃣ μž‘μ—…ν•œ λ‚΄μš© μš”μ•½

λ‹€μŒκ³Ό 같은 ν˜•νƒœλ‘œ μ μ–΄μ£Όμ„Έμš” (ex. - [ ] μž‘μ—… λ‚΄μš© || - [x] μž‘μ—… λ‚΄μš©)

  • μŠ€ν¬λ‘€ν•΄μ„œ ν•΄λ‹Ή μ˜μ—­μ˜ μ†Œμ…œ 뢄석이 보일 λ•Œ μ• λ‹ˆλ©”μ΄μ…˜μ΄ μˆ˜μ •λ˜λ„λ‘ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • μ†Œμ…œ 뢄석 λ””μžμΈ μ™„μ„±ν–ˆμŠ΅λ‹ˆλ‹€.

🍩 μœ„ν‚€μ— 올릴 λ‚΄μš© 정리

μœ„ν‚€μ— 올릴 λ‚΄μš©μ„ μ •λ¦¬ν•΄μ£Όμ„Έμš” (자유둭게 μ μ–΄μ£Όμ„Έμš”)

βš™οΈ 이슈 번호

κ΄€λ ¨λœ 이슈λ₯Ό μ μ–΄μ£Όμ„Έμš” (ex. -close #37 || #37)

@gariguri gariguri self-requested a review June 21, 2024 05:53
gariguri
gariguri approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@gariguri gariguri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ””μžμΈ 정말 μ΄λΏŒλ„€μš© κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹Ή~!~!πŸ˜€

JaeIn1
JaeIn1 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@JaeIn1 JaeIn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—­μ‹œ λŒ€λ‹¨ν•˜μ‹­λ‹ˆλ‹€ LGTMπŸ‘

@ShinHeeEul ShinHeeEul merged commit 43a3365 into develop Jun 21, 2024
@ShinHeeEul ShinHeeEul deleted the feat/graphs branch June 21, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaeIn1 JaeIn1 JaeIn1 approved these changes

@gariguri gariguri gariguri approved these changes

Assignees

@donginLee donginLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@donginLee @JaeIn1 @gariguri @ShinHeeEul