-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocpp-v1_6: BootNotificationRequest: Allow optional properties to be set null #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The copy right year should be bumped up to 2022
ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/core/test/BootNotificationRequestTest.java
Outdated
Show resolved
Hide resolved
@TVolden Updated |
It's weird. The maven build failed because of some java doc. |
Maybe try adding the target source to the pom.xml file: --- a/ocpp-v1_6/pom.xml
+++ b/ocpp-v1_6/pom.xml
@@ -116,6 +116,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <source>8</source>
+ </configuration>
<version>2.9.1</version>
<executions>
<execution> |
@TVolden Added |
Are we seeing this here? https://stackoverflow.com/a/74185633 |
Possible. The version seems to match.
|
It seems so.
So how to fix it? |
I've removed my not-working fix commit from this branch.
Can we downgrade to Temurin 11.0.16 or upgrade to a fixed version? |
Is the javadoc output actually deployed or used somewhere? |
Added commit doing that. |
It worked, amazing work @bantu. |
Fix #221