Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cypress tests use chrome version 90 in ci #1165

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Make cypress tests use chrome version 90 in ci #1165

merged 1 commit into from
Jun 22, 2021

Conversation

asnaith
Copy link
Contributor

@asnaith asnaith commented Jun 21, 2021

Related to "Improvement B" mentioned in #1131

What I changed

  • Updated the docker container being used in ci
  • Specified cypress to run tests in the chrome browser instead of the default (electron)

@render
Copy link

render bot commented Jun 21, 2021

Your Render PR Server URL is https://files-ui-stage-pr-1165.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c38hk0r2v8p1mrnt80ag.

@render
Copy link

render bot commented Jun 21, 2021

Your Render PR Server URL is https://storage-ui-stage-pr-1165.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c38hk1b2v8p1mrnt80r0.

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jun 21, 2021
@asnaith asnaith marked this pull request as ready for review June 21, 2021 23:04
@asnaith asnaith requested review from Tbaut, FSM1, tanmoyAtb, a team and RyRy79261 and removed request for tanmoyAtb, FSM1, Tbaut and a team June 21, 2021 23:04
@asnaith asnaith added the Testing Added to issues to signal that it is part of an epic label Jun 21, 2021
@asnaith
Copy link
Contributor Author

asnaith commented Jun 21, 2021

Screen Shot 2021-06-21 at 4 52 50 PM

All is good in CI. The changes are being applied.

Tbaut
Tbaut approved these changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tbaut Tbaut added Status: Review Needed 👀 Added to PRs when they need more review and removed Testing Added to issues to signal that it is part of an epic labels Jun 22, 2021
@Tbaut Tbaut merged commit c5c925f into dev Jun 22, 2021
@Tbaut Tbaut deleted the mnt/make-cypress-use-chrome-in-ci-1131 branch June 22, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@Tbaut Tbaut Tbaut approved these changes

@FSM1 FSM1 Awaiting requested review from FSM1

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asnaith @RyRy79261 @Tbaut