Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase max attestation inclusion slot for post deneb blocks #6522

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: increase max attestation inclusion slot for post deneb blocks #6522

merged 1 commit into from
Mar 8, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Mar 8, 2024

Motivation

EIP-7045 allows to include attestations from current and previous epoch in block.

https://eips.ethereum.org/EIPS/eip-7045#consensus-layer

Modify process_attestation to not have an upper bound on the slot check and instead define the inclusion range via the minimum slot as well as the target epoch being in either current or previous epoch.

Description

Increase max attestation inclusion slot for post deneb blocks by skipping upper bound on the slot check.

Note that we verify before that attestation target epoch is in previous or current epoch

lodestar/packages/beacon-node/src/chain/opPools/aggregatedAttestationPool.ts

Lines 142 to 145 in adc0534

// validateAttestation condition: Attestation target epoch not in previous or current epoch
if (!(epoch === stateEpoch || epoch === statePrevEpoch)) {
continue; // Invalid attestations
}

Ref: https://github.com/ethereum/consensus-specs/blob/v1.4.0-beta.7/specs/deneb/beacon-chain.md#modified-process_attestation

related ethereum/consensus-specs#3360

@nflaig nflaig force-pushed the nflaig/fix-eip7045-block-processing branch from 2929cb6 to efb3fea Compare March 8, 2024 11:55
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Merging #6522 (efb3fea) into unstable (36f50cf) will decrease coverage by 0.01%.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6522      +/-   ##
============================================
- Coverage     61.53%   61.53%   -0.01%     
============================================
  Files           556      556              
  Lines         58648    58647       -1     
  Branches       1847     1846       -1     
============================================
- Hits          36088    36086       -2     
- Misses        22520    22521       +1     
  Partials         40       40

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: bbdc7b3 Previous: adc0534 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 401.33 us/op 792.50 us/op 0.51
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 50.302 us/op 83.873 us/op 0.60
BLS verify - blst-native 1.1217 ms/op 1.3337 ms/op 0.84
BLS verifyMultipleSignatures 3 - blst-native 2.3963 ms/op 2.7201 ms/op 0.88
BLS verifyMultipleSignatures 8 - blst-native 5.3007 ms/op 6.0052 ms/op 0.88
BLS verifyMultipleSignatures 32 - blst-native 19.572 ms/op 21.969 ms/op 0.89
BLS verifyMultipleSignatures 64 - blst-native 38.445 ms/op 43.166 ms/op 0.89
BLS verifyMultipleSignatures 128 - blst-native 76.633 ms/op 86.357 ms/op 0.89
BLS deserializing 10000 signatures 793.62 ms/op 924.28 ms/op 0.86
BLS deserializing 100000 signatures 8.1277 s/op 9.4577 s/op 0.86
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.0645 ms/op 1.3320 ms/op 0.80
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.2762 ms/op 1.6456 ms/op 0.78
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.0171 ms/op 2.9228 ms/op 0.69
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.3062 ms/op 4.4102 ms/op 0.75
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.6892 ms/op 7.9726 ms/op 0.84
BLS aggregatePubkeys 32 - blst-native 21.723 us/op 25.918 us/op 0.84
BLS aggregatePubkeys 128 - blst-native 86.113 us/op 100.81 us/op 0.85
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 39.356 ms/op 67.440 ms/op 0.58
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 53.117 ms/op 63.667 ms/op 0.83
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 25.557 ms/op 36.440 ms/op 0.70
getSlashingsAndExits - default max 109.67 us/op 203.78 us/op 0.54
getSlashingsAndExits - 2k 578.62 us/op 651.26 us/op 0.89
proposeBlockBody type=full, size=empty 4.3592 ms/op 5.3843 ms/op 0.81
isKnown best case - 1 super set check 501.00 ns/op 379.00 ns/op 1.32
isKnown normal case - 2 super set checks 544.00 ns/op 532.00 ns/op 1.02
isKnown worse case - 16 super set checks 646.00 ns/op 599.00 ns/op 1.08
CheckpointStateCache - add get delete 6.2310 us/op 7.6150 us/op 0.82
validate api signedAggregateAndProof - struct 2.3885 ms/op 3.0116 ms/op 0.79
validate gossip signedAggregateAndProof - struct 2.3827 ms/op 2.8203 ms/op 0.84
validate gossip attestation - vc 640000 1.1623 ms/op 1.3874 ms/op 0.84
batch validate gossip attestation - vc 640000 - chunk 32 159.41 us/op 168.47 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 64 138.88 us/op 146.72 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 128 127.27 us/op 141.39 us/op 0.90
batch validate gossip attestation - vc 640000 - chunk 256 106.92 us/op 130.31 us/op 0.82
pickEth1Vote - no votes 866.15 us/op 1.1663 ms/op 0.74
pickEth1Vote - max votes 10.798 ms/op 9.8931 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot value x2048 20.581 ms/op 16.455 ms/op 1.25
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 24.993 ms/op 23.089 ms/op 1.08
pickEth1Vote - Eth1Data fastSerialize value x2048 392.36 us/op 620.45 us/op 0.63
pickEth1Vote - Eth1Data fastSerialize tree x2048 3.0682 ms/op 4.3950 ms/op 0.70
bytes32 toHexString 435.00 ns/op 532.00 ns/op 0.82
bytes32 Buffer.toString(hex) 307.00 ns/op 295.00 ns/op 1.04
bytes32 Buffer.toString(hex) from Uint8Array 405.00 ns/op 428.00 ns/op 0.95
bytes32 Buffer.toString(hex) + 0x 313.00 ns/op 292.00 ns/op 1.07
Object access 1 prop 0.18900 ns/op 0.16800 ns/op 1.13
Map access 1 prop 0.18100 ns/op 0.15400 ns/op 1.18
Object get x1000 4.8470 ns/op 7.3500 ns/op 0.66
Map get x1000 0.69900 ns/op 0.76700 ns/op 0.91
Object set x1000 28.928 ns/op 52.256 ns/op 0.55
Map set x1000 17.192 ns/op 41.214 ns/op 0.42
Return object 10000 times 0.21670 ns/op 0.24490 ns/op 0.88
Throw Error 10000 times 2.5437 us/op 3.9163 us/op 0.65
fastMsgIdFn sha256 / 200 bytes 1.9400 us/op 3.3970 us/op 0.57
fastMsgIdFn h32 xxhash / 200 bytes 271.00 ns/op 317.00 ns/op 0.85
fastMsgIdFn h64 xxhash / 200 bytes 325.00 ns/op 348.00 ns/op 0.93
fastMsgIdFn sha256 / 1000 bytes 5.9360 us/op 11.370 us/op 0.52
fastMsgIdFn h32 xxhash / 1000 bytes 389.00 ns/op 417.00 ns/op 0.93
fastMsgIdFn h64 xxhash / 1000 bytes 397.00 ns/op 458.00 ns/op 0.87
fastMsgIdFn sha256 / 10000 bytes 50.304 us/op 104.97 us/op 0.48
fastMsgIdFn h32 xxhash / 10000 bytes 1.8770 us/op 1.9730 us/op 0.95
fastMsgIdFn h64 xxhash / 10000 bytes 1.3460 us/op 1.3830 us/op 0.97
send data - 1000 256B messages 11.925 ms/op 19.901 ms/op 0.60
send data - 1000 512B messages 14.514 ms/op 28.055 ms/op 0.52
send data - 1000 1024B messages 27.735 ms/op 41.059 ms/op 0.68
send data - 1000 1200B messages 28.463 ms/op 37.236 ms/op 0.76
send data - 1000 2048B messages 38.587 ms/op 48.863 ms/op 0.79
send data - 1000 4096B messages 32.090 ms/op 44.281 ms/op 0.72
send data - 1000 16384B messages 83.173 ms/op 117.00 ms/op 0.71
send data - 1000 65536B messages 464.94 ms/op 471.40 ms/op 0.99
enrSubnets - fastDeserialize 64 bits 1.0270 us/op 1.3310 us/op 0.77
enrSubnets - ssz BitVector 64 bits 477.00 ns/op 445.00 ns/op 1.07
enrSubnets - fastDeserialize 4 bits 212.00 ns/op 196.00 ns/op 1.08
enrSubnets - ssz BitVector 4 bits 417.00 ns/op 466.00 ns/op 0.89
prioritizePeers score -10:0 att 32-0.1 sync 2-0 72.637 us/op 104.86 us/op 0.69
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 83.210 us/op 132.87 us/op 0.63
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 106.95 us/op 175.69 us/op 0.61
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 225.17 us/op 297.62 us/op 0.76
prioritizePeers score 0:0 att 64-1 sync 4-1 200.54 us/op 368.83 us/op 0.54
array of 16000 items push then shift 1.2850 us/op 1.6256 us/op 0.79
LinkedList of 16000 items push then shift 6.1090 ns/op 9.0490 ns/op 0.68
array of 16000 items push then pop 83.115 ns/op 59.223 ns/op 1.40
LinkedList of 16000 items push then pop 5.5170 ns/op 8.8570 ns/op 0.62
array of 24000 items push then shift 1.8980 us/op 2.4041 us/op 0.79
LinkedList of 24000 items push then shift 6.0310 ns/op 8.8960 ns/op 0.68
array of 24000 items push then pop 79.577 ns/op 114.00 ns/op 0.70
LinkedList of 24000 items push then pop 5.8850 ns/op 8.7010 ns/op 0.68
intersect bitArray bitLen 8 4.8760 ns/op 5.7850 ns/op 0.84
intersect array and set length 8 48.936 ns/op 64.743 ns/op 0.76
intersect bitArray bitLen 128 29.377 ns/op 35.272 ns/op 0.83
intersect array and set length 128 688.72 ns/op 948.41 ns/op 0.73
bitArray.getTrueBitIndexes() bitLen 128 1.1700 us/op 1.5620 us/op 0.75
bitArray.getTrueBitIndexes() bitLen 248 1.8700 us/op 2.8920 us/op 0.65
bitArray.getTrueBitIndexes() bitLen 512 3.4820 us/op 5.2420 us/op 0.66
Buffer.concat 32 items 840.00 ns/op 1.0970 us/op 0.77
Uint8Array.set 32 items 1.7500 us/op 2.6580 us/op 0.66
Set add up to 64 items then delete first 1.7538 us/op 4.3039 us/op 0.41
OrderedSet add up to 64 items then delete first 2.5993 us/op 5.3629 us/op 0.48
Set add up to 64 items then delete last 1.8975 us/op 4.5334 us/op 0.42
OrderedSet add up to 64 items then delete last 3.1255 us/op 5.6186 us/op 0.56
Set add up to 64 items then delete middle 1.9954 us/op 4.4868 us/op 0.44
OrderedSet add up to 64 items then delete middle 3.9523 us/op 6.9857 us/op 0.57
Set add up to 128 items then delete first 3.7373 us/op 9.4838 us/op 0.39
OrderedSet add up to 128 items then delete first 6.2709 us/op 12.161 us/op 0.52
Set add up to 128 items then delete last 3.7821 us/op 9.1715 us/op 0.41
OrderedSet add up to 128 items then delete last 5.7046 us/op 11.275 us/op 0.51
Set add up to 128 items then delete middle 3.7918 us/op 9.0236 us/op 0.42
OrderedSet add up to 128 items then delete middle 10.647 us/op 16.624 us/op 0.64
Set add up to 256 items then delete first 7.6754 us/op 18.709 us/op 0.41
OrderedSet add up to 256 items then delete first 12.124 us/op 24.900 us/op 0.49
Set add up to 256 items then delete last 7.4223 us/op 17.899 us/op 0.41
OrderedSet add up to 256 items then delete last 11.325 us/op 22.785 us/op 0.50
Set add up to 256 items then delete middle 7.5231 us/op 18.059 us/op 0.42
OrderedSet add up to 256 items then delete middle 30.408 us/op 44.531 us/op 0.68
transfer serialized Status (84 B) 1.3980 us/op 1.6270 us/op 0.86
copy serialized Status (84 B) 1.1490 us/op 1.1970 us/op 0.96
transfer serialized SignedVoluntaryExit (112 B) 1.4250 us/op 1.8140 us/op 0.79
copy serialized SignedVoluntaryExit (112 B) 1.2400 us/op 1.2770 us/op 0.97
transfer serialized ProposerSlashing (416 B) 1.4640 us/op 2.8560 us/op 0.51
copy serialized ProposerSlashing (416 B) 1.5680 us/op 2.6770 us/op 0.59
transfer serialized Attestation (485 B) 1.9420 us/op 2.6360 us/op 0.74
copy serialized Attestation (485 B) 1.2220 us/op 2.4990 us/op 0.49
transfer serialized AttesterSlashing (33232 B) 1.5740 us/op 2.4860 us/op 0.63
copy serialized AttesterSlashing (33232 B) 3.3480 us/op 6.3920 us/op 0.52
transfer serialized Small SignedBeaconBlock (128000 B) 1.7120 us/op 2.8310 us/op 0.60
copy serialized Small SignedBeaconBlock (128000 B) 8.4120 us/op 15.038 us/op 0.56
transfer serialized Avg SignedBeaconBlock (200000 B) 1.8610 us/op 3.3940 us/op 0.55
copy serialized Avg SignedBeaconBlock (200000 B) 12.172 us/op 20.602 us/op 0.59
transfer serialized BlobsSidecar (524380 B) 2.1620 us/op 3.4700 us/op 0.62
copy serialized BlobsSidecar (524380 B) 74.893 us/op 120.55 us/op 0.62
transfer serialized Big SignedBeaconBlock (1000000 B) 2.7010 us/op 3.0400 us/op 0.89
copy serialized Big SignedBeaconBlock (1000000 B) 212.55 us/op 380.64 us/op 0.56
pass gossip attestations to forkchoice per slot 2.7989 ms/op 3.7688 ms/op 0.74
forkChoice updateHead vc 100000 bc 64 eq 0 486.13 us/op 672.05 us/op 0.72
forkChoice updateHead vc 600000 bc 64 eq 0 2.6138 ms/op 4.0664 ms/op 0.64
forkChoice updateHead vc 1000000 bc 64 eq 0 4.4824 ms/op 6.8946 ms/op 0.65
forkChoice updateHead vc 600000 bc 320 eq 0 2.5829 ms/op 4.1540 ms/op 0.62
forkChoice updateHead vc 600000 bc 1200 eq 0 2.6977 ms/op 4.2837 ms/op 0.63
forkChoice updateHead vc 600000 bc 7200 eq 0 3.2221 ms/op 5.3699 ms/op 0.60
forkChoice updateHead vc 600000 bc 64 eq 1000 9.8520 ms/op 10.915 ms/op 0.90
forkChoice updateHead vc 600000 bc 64 eq 10000 9.6510 ms/op 11.636 ms/op 0.83
forkChoice updateHead vc 600000 bc 64 eq 300000 12.010 ms/op 15.467 ms/op 0.78
computeDeltas 500000 validators 300 proto nodes 3.0829 ms/op 6.6073 ms/op 0.47
computeDeltas 500000 validators 1200 proto nodes 2.9492 ms/op 6.3694 ms/op 0.46
computeDeltas 500000 validators 7200 proto nodes 2.9400 ms/op 6.4834 ms/op 0.45
computeDeltas 750000 validators 300 proto nodes 4.5594 ms/op 9.7722 ms/op 0.47
computeDeltas 750000 validators 1200 proto nodes 4.3725 ms/op 9.7933 ms/op 0.45
computeDeltas 750000 validators 7200 proto nodes 4.5070 ms/op 9.7276 ms/op 0.46
computeDeltas 1400000 validators 300 proto nodes 9.1006 ms/op 17.968 ms/op 0.51
computeDeltas 1400000 validators 1200 proto nodes 9.2302 ms/op 17.844 ms/op 0.52
computeDeltas 1400000 validators 7200 proto nodes 9.0529 ms/op 17.858 ms/op 0.51
computeDeltas 2100000 validators 300 proto nodes 14.491 ms/op 26.869 ms/op 0.54
computeDeltas 2100000 validators 1200 proto nodes 14.386 ms/op 27.255 ms/op 0.53
computeDeltas 2100000 validators 7200 proto nodes 13.722 ms/op 26.350 ms/op 0.52
altair processAttestation - 250000 vs - 7PWei normalcase 2.1873 ms/op 2.9283 ms/op 0.75
altair processAttestation - 250000 vs - 7PWei worstcase 3.4958 ms/op 4.0120 ms/op 0.87
altair processAttestation - setStatus - 1/6 committees join 99.141 us/op 213.67 us/op 0.46
altair processAttestation - setStatus - 1/3 committees join 214.16 us/op 429.12 us/op 0.50
altair processAttestation - setStatus - 1/2 committees join 291.92 us/op 581.93 us/op 0.50
altair processAttestation - setStatus - 2/3 committees join 381.31 us/op 652.26 us/op 0.58
altair processAttestation - setStatus - 4/5 committees join 516.08 us/op 995.01 us/op 0.52
altair processAttestation - setStatus - 100% committees join 596.09 us/op 1.1058 ms/op 0.54
altair processBlock - 250000 vs - 7PWei normalcase 7.8754 ms/op 7.9389 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase hashState 38.449 ms/op 34.314 ms/op 1.12
altair processBlock - 250000 vs - 7PWei worstcase 30.589 ms/op 38.807 ms/op 0.79
altair processBlock - 250000 vs - 7PWei worstcase hashState 93.367 ms/op 90.515 ms/op 1.03
phase0 processBlock - 250000 vs - 7PWei normalcase 2.3364 ms/op 2.8609 ms/op 0.82
phase0 processBlock - 250000 vs - 7PWei worstcase 25.576 ms/op 28.893 ms/op 0.89
altair processEth1Data - 250000 vs - 7PWei normalcase 459.21 us/op 476.37 us/op 0.96
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.8340 us/op 7.4280 us/op 1.19
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 54.913 us/op 32.848 us/op 1.67
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 18.650 us/op 10.765 us/op 1.73
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 14.073 us/op 10.203 us/op 1.38
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 182.15 us/op 119.64 us/op 1.52
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.3942 ms/op 1.0326 ms/op 1.35
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.3581 ms/op 1.4912 ms/op 0.91
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.1590 ms/op 1.5262 ms/op 0.76
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.7203 ms/op 3.3999 ms/op 0.80
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.0393 ms/op 2.3292 ms/op 0.88
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.0091 ms/op 5.2056 ms/op 0.77
Tree 40 250000 create 318.45 ms/op 343.02 ms/op 0.93
Tree 40 250000 get(125000) 123.04 ns/op 193.49 ns/op 0.64
Tree 40 250000 set(125000) 886.74 ns/op 1.0295 us/op 0.86
Tree 40 250000 toArray() 15.423 ms/op 20.186 ms/op 0.76
Tree 40 250000 iterate all - toArray() + loop 10.350 ms/op 17.659 ms/op 0.59
Tree 40 250000 iterate all - get(i) 40.541 ms/op 64.553 ms/op 0.63
MutableVector 250000 create 11.343 ms/op 12.070 ms/op 0.94
MutableVector 250000 get(125000) 5.3530 ns/op 6.3850 ns/op 0.84
MutableVector 250000 set(125000) 186.76 ns/op 250.73 ns/op 0.74
MutableVector 250000 toArray() 2.1340 ms/op 2.7717 ms/op 0.77
MutableVector 250000 iterate all - toArray() + loop 2.1872 ms/op 2.8871 ms/op 0.76
MutableVector 250000 iterate all - get(i) 1.3515 ms/op 1.5245 ms/op 0.89
Array 250000 create 2.0160 ms/op 2.5386 ms/op 0.79
Array 250000 clone - spread 1.1050 ms/op 1.1837 ms/op 0.93
Array 250000 get(125000) 1.0310 ns/op 1.0230 ns/op 1.01
Array 250000 set(125000) 1.2430 ns/op 4.0410 ns/op 0.31
Array 250000 iterate all - loop 153.27 us/op 165.44 us/op 0.93
effectiveBalanceIncrements clone Uint8Array 300000 14.142 us/op 28.045 us/op 0.50
effectiveBalanceIncrements clone MutableVector 300000 406.00 ns/op 360.00 ns/op 1.13
effectiveBalanceIncrements rw all Uint8Array 300000 184.25 us/op 199.10 us/op 0.93
effectiveBalanceIncrements rw all MutableVector 300000 64.374 ms/op 81.252 ms/op 0.79
phase0 afterProcessEpoch - 250000 vs - 7PWei 77.151 ms/op 112.14 ms/op 0.69
phase0 beforeProcessEpoch - 250000 vs - 7PWei 45.185 ms/op 50.768 ms/op 0.89
altair processEpoch - mainnet_e81889 489.13 ms/op 484.06 ms/op 1.01
mainnet_e81889 - altair beforeProcessEpoch 83.175 ms/op 81.149 ms/op 1.02
mainnet_e81889 - altair processJustificationAndFinalization 13.348 us/op 15.167 us/op 0.88
mainnet_e81889 - altair processInactivityUpdates 5.7929 ms/op 5.6592 ms/op 1.02
mainnet_e81889 - altair processRewardsAndPenalties 56.818 ms/op 39.039 ms/op 1.46
mainnet_e81889 - altair processRegistryUpdates 1.8680 us/op 2.3670 us/op 0.79
mainnet_e81889 - altair processSlashings 594.00 ns/op 490.00 ns/op 1.21
mainnet_e81889 - altair processEth1DataReset 603.00 ns/op 467.00 ns/op 1.29
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.7639 ms/op 1.4377 ms/op 1.23
mainnet_e81889 - altair processSlashingsReset 3.2640 us/op 3.3510 us/op 0.97
mainnet_e81889 - altair processRandaoMixesReset 5.7370 us/op 4.6060 us/op 1.25
mainnet_e81889 - altair processHistoricalRootsUpdate 792.00 ns/op 675.00 ns/op 1.17
mainnet_e81889 - altair processParticipationFlagUpdates 3.5080 us/op 3.2150 us/op 1.09
mainnet_e81889 - altair processSyncCommitteeUpdates 785.00 ns/op 668.00 ns/op 1.18
mainnet_e81889 - altair afterProcessEpoch 83.095 ms/op 115.69 ms/op 0.72
capella processEpoch - mainnet_e217614 1.4932 s/op 1.7714 s/op 0.84
mainnet_e217614 - capella beforeProcessEpoch 380.77 ms/op 452.12 ms/op 0.84
mainnet_e217614 - capella processJustificationAndFinalization 10.014 us/op 17.060 us/op 0.59
mainnet_e217614 - capella processInactivityUpdates 15.365 ms/op 22.958 ms/op 0.67
mainnet_e217614 - capella processRewardsAndPenalties 360.28 ms/op 476.85 ms/op 0.76
mainnet_e217614 - capella processRegistryUpdates 18.175 us/op 22.317 us/op 0.81
mainnet_e217614 - capella processSlashings 703.00 ns/op 451.00 ns/op 1.56
mainnet_e217614 - capella processEth1DataReset 537.00 ns/op 537.00 ns/op 1.00
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.8865 ms/op 5.4559 ms/op 0.71
mainnet_e217614 - capella processSlashingsReset 1.9220 us/op 3.2850 us/op 0.59
mainnet_e217614 - capella processRandaoMixesReset 2.9390 us/op 5.2710 us/op 0.56
mainnet_e217614 - capella processHistoricalRootsUpdate 565.00 ns/op 602.00 ns/op 0.94
mainnet_e217614 - capella processParticipationFlagUpdates 1.2350 us/op 4.5950 us/op 0.27
mainnet_e217614 - capella afterProcessEpoch 196.57 ms/op 307.65 ms/op 0.64
phase0 processEpoch - mainnet_e58758 418.61 ms/op 516.91 ms/op 0.81
mainnet_e58758 - phase0 beforeProcessEpoch 121.65 ms/op 144.26 ms/op 0.84
mainnet_e58758 - phase0 processJustificationAndFinalization 14.951 us/op 16.297 us/op 0.92
mainnet_e58758 - phase0 processRewardsAndPenalties 51.162 ms/op 53.819 ms/op 0.95
mainnet_e58758 - phase0 processRegistryUpdates 8.5860 us/op 9.7940 us/op 0.88
mainnet_e58758 - phase0 processSlashings 427.00 ns/op 635.00 ns/op 0.67
mainnet_e58758 - phase0 processEth1DataReset 594.00 ns/op 816.00 ns/op 0.73
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.5571 ms/op 1.1929 ms/op 1.31
mainnet_e58758 - phase0 processSlashingsReset 2.8840 us/op 2.4360 us/op 1.18
mainnet_e58758 - phase0 processRandaoMixesReset 3.6760 us/op 4.2400 us/op 0.87
mainnet_e58758 - phase0 processHistoricalRootsUpdate 680.00 ns/op 606.00 ns/op 1.12
mainnet_e58758 - phase0 processParticipationRecordUpdates 7.0720 us/op 4.9480 us/op 1.43
mainnet_e58758 - phase0 afterProcessEpoch 73.105 ms/op 101.74 ms/op 0.72
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.0337 ms/op 1.3767 ms/op 0.75
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.8562 ms/op 1.5362 ms/op 1.21
altair processInactivityUpdates - 250000 normalcase 17.654 ms/op 32.523 ms/op 0.54
altair processInactivityUpdates - 250000 worstcase 19.335 ms/op 24.252 ms/op 0.80
phase0 processRegistryUpdates - 250000 normalcase 3.8370 us/op 14.537 us/op 0.26
phase0 processRegistryUpdates - 250000 badcase_full_deposits 395.95 us/op 462.05 us/op 0.86
phase0 processRegistryUpdates - 250000 worstcase 0.5 106.45 ms/op 142.86 ms/op 0.75
altair processRewardsAndPenalties - 250000 normalcase 58.619 ms/op 65.509 ms/op 0.89
altair processRewardsAndPenalties - 250000 worstcase 57.603 ms/op 61.436 ms/op 0.94
phase0 getAttestationDeltas - 250000 normalcase 5.6070 ms/op 10.792 ms/op 0.52
phase0 getAttestationDeltas - 250000 worstcase 6.9525 ms/op 9.9359 ms/op 0.70
phase0 processSlashings - 250000 worstcase 84.753 us/op 97.945 us/op 0.87
altair processSyncCommitteeUpdates - 250000 102.53 ms/op 161.07 ms/op 0.64
BeaconState.hashTreeRoot - No change 393.00 ns/op 371.00 ns/op 1.06
BeaconState.hashTreeRoot - 1 full validator 102.36 us/op 122.53 us/op 0.84
BeaconState.hashTreeRoot - 32 full validator 827.84 us/op 1.1514 ms/op 0.72
BeaconState.hashTreeRoot - 512 full validator 9.0933 ms/op 14.558 ms/op 0.62
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 98.345 us/op 183.32 us/op 0.54
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.3545 ms/op 2.1488 ms/op 1.10
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 27.366 ms/op 33.190 ms/op 0.82
BeaconState.hashTreeRoot - 1 balances 126.50 us/op 135.09 us/op 0.94
BeaconState.hashTreeRoot - 32 balances 1.1087 ms/op 1.2129 ms/op 0.91
BeaconState.hashTreeRoot - 512 balances 11.121 ms/op 13.793 ms/op 0.81
BeaconState.hashTreeRoot - 250000 balances 193.53 ms/op 225.18 ms/op 0.86
aggregationBits - 2048 els - zipIndexesInBitList 20.147 us/op 70.920 us/op 0.28
byteArrayEquals 32 59.414 ns/op 75.090 ns/op 0.79
Buffer.compare 32 33.627 ns/op 55.817 ns/op 0.60
byteArrayEquals 1024 1.5680 us/op 2.0457 us/op 0.77
Buffer.compare 1024 39.734 ns/op 70.502 ns/op 0.56
byteArrayEquals 16384 24.965 us/op 32.557 us/op 0.77
Buffer.compare 16384 190.47 ns/op 270.28 ns/op 0.70
byteArrayEquals 123687377 185.99 ms/op 252.72 ms/op 0.74
Buffer.compare 123687377 5.2683 ms/op 8.5285 ms/op 0.62
byteArrayEquals 32 - diff last byte 55.734 ns/op 74.156 ns/op 0.75
Buffer.compare 32 - diff last byte 33.835 ns/op 57.229 ns/op 0.59
byteArrayEquals 1024 - diff last byte 1.5484 us/op 2.6518 us/op 0.58
Buffer.compare 1024 - diff last byte 39.256 ns/op 81.031 ns/op 0.48
byteArrayEquals 16384 - diff last byte 25.099 us/op 33.825 us/op 0.74
Buffer.compare 16384 - diff last byte 178.47 ns/op 254.75 ns/op 0.70
byteArrayEquals 123687377 - diff last byte 184.91 ms/op 257.30 ms/op 0.72
Buffer.compare 123687377 - diff last byte 3.7398 ms/op 6.9196 ms/op 0.54
byteArrayEquals 32 - random bytes 4.6640 ns/op 5.3910 ns/op 0.87
Buffer.compare 32 - random bytes 39.232 ns/op 62.462 ns/op 0.63
byteArrayEquals 1024 - random bytes 4.4890 ns/op 5.2140 ns/op 0.86
Buffer.compare 1024 - random bytes 37.669 ns/op 60.655 ns/op 0.62
byteArrayEquals 16384 - random bytes 4.4650 ns/op 5.1710 ns/op 0.86
Buffer.compare 16384 - random bytes 37.727 ns/op 60.324 ns/op 0.63
byteArrayEquals 123687377 - random bytes 8.0200 ns/op 8.4300 ns/op 0.95
Buffer.compare 123687377 - random bytes 43.550 ns/op 63.500 ns/op 0.69
regular array get 100000 times 41.077 us/op 43.936 us/op 0.93
wrappedArray get 100000 times 41.163 us/op 44.778 us/op 0.92
arrayWithProxy get 100000 times 10.528 ms/op 14.936 ms/op 0.70
ssz.Root.equals 54.226 ns/op 54.392 ns/op 1.00
byteArrayEquals 53.697 ns/op 54.348 ns/op 0.99
Buffer.compare 9.3050 ns/op 11.401 ns/op 0.82
shuffle list - 16384 els 5.8100 ms/op 8.6133 ms/op 0.67
shuffle list - 250000 els 85.439 ms/op 124.99 ms/op 0.68
processSlot - 1 slots 16.078 us/op 17.420 us/op 0.92
processSlot - 32 slots 3.2042 ms/op 3.3153 ms/op 0.97
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 51.080 ms/op 58.732 ms/op 0.87
getCommitteeAssignments - req 1 vs - 250000 vc 2.4250 ms/op 2.6537 ms/op 0.91
getCommitteeAssignments - req 100 vs - 250000 vc 3.6018 ms/op 3.8348 ms/op 0.94
getCommitteeAssignments - req 1000 vs - 250000 vc 3.8565 ms/op 4.1876 ms/op 0.92
findModifiedValidators - 10000 modified validators 398.94 ms/op 556.14 ms/op 0.72
findModifiedValidators - 1000 modified validators 320.00 ms/op 385.66 ms/op 0.83
findModifiedValidators - 100 modified validators 302.11 ms/op 415.96 ms/op 0.73
findModifiedValidators - 10 modified validators 297.97 ms/op 394.53 ms/op 0.76
findModifiedValidators - 1 modified validators 301.71 ms/op 399.70 ms/op 0.75
findModifiedValidators - no difference 288.59 ms/op 410.56 ms/op 0.70
compare ViewDUs 3.8567 s/op 4.2832 s/op 0.90
compare each validator Uint8Array 1.6132 s/op 1.5276 s/op 1.06
compare ViewDU to Uint8Array 1.0517 s/op 1.0780 s/op 0.98
migrate state 1000000 validators, 24 modified, 0 new 703.48 ms/op 787.74 ms/op 0.89
migrate state 1000000 validators, 1700 modified, 1000 new 896.99 ms/op 1.0623 s/op 0.84
migrate state 1000000 validators, 3400 modified, 2000 new 1.1362 s/op 1.2952 s/op 0.88
migrate state 1500000 validators, 24 modified, 0 new 739.02 ms/op 776.07 ms/op 0.95
migrate state 1500000 validators, 1700 modified, 1000 new 1.0305 s/op 1.0834 s/op 0.95
migrate state 1500000 validators, 3400 modified, 2000 new 1.1892 s/op 1.3105 s/op 0.91
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.6400 ns/op 4.2100 ns/op 1.10
state getBlockRootAtSlot - 250000 vs - 7PWei 605.75 ns/op 615.59 ns/op 0.98
computeProposers - vc 250000 6.6956 ms/op 8.6634 ms/op 0.77
computeEpochShuffling - vc 250000 89.443 ms/op 122.81 ms/op 0.73
getNextSyncCommittee - vc 250000 106.65 ms/op 159.66 ms/op 0.67
computeSigningRoot for AttestationData 24.490 us/op 28.031 us/op 0.87
hash AttestationData serialized data then Buffer.toString(base64) 1.2631 us/op 2.2450 us/op 0.56
toHexString serialized data 808.25 ns/op 1.0674 us/op 0.76
Buffer.toString(base64) 155.17 ns/op 212.93 ns/op 0.73

by benchmarkbot/action

@nflaig nflaig marked this pull request as ready for review March 8, 2024 12:44
@nflaig nflaig requested a review from a team as a code owner March 8, 2024 12:44
g11tech
g11tech approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech merged commit cae26be into unstable Mar 8, 2024
19 of 20 checks passed
@g11tech g11tech deleted the nflaig/fix-eip7045-block-processing branch March 8, 2024 12:51
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.17.0 🎉

@nflaig nflaig mentioned this pull request Mar 31, 2025
Merged
nflaig added a commit that referenced this pull request Apr 1, 2025
@nflaig
fix: update pruning to account for increase of max attestation inclus…
8b43dbe 
…ion slot post-deneb (#7636)

**Motivation**

[EIP-7045](https://eips.ethereum.org/EIPS/eip-7045) allows to include
attestations from current and previous epoch in block, while we already
account for increase of max attestation inclusion slot post-deneb when
packing the block (#6522), we
did not update our pruning and as of right now we will remove all
attestations older than `clockSlot - SLOTS_PER_EPOCH`.

This is not problematic during healthy network conditions but as
EIP-7045 shows this is important, especially during non-finality where
those attestations could become critical to include.
> As discussed in the Motivation, extending this max inclusion slot to
the end of the next epoch is critical for LMD-GHOST security proofs and
confirmation rule.


**Description**

Update pruning to account for increase of max attestation inclusion slot
post-deneb, ie. we will retain attestations for current and previous
epoch instead of previous behavior which removed attestations older than
32 slots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nflaig @wemeetagain @g11tech