Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule gnosis merge #4804

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Schedule gnosis merge #4804

merged 3 commits into from
Nov 23, 2022

Conversation

dapplion
Copy link
Contributor

Motivation

Gnosis Bellatrix is scheduled for Nov 30th, in ~ 7 days. Since 1.3.0 is not ready yet, release a hotfix including just this parameters

Description

Schedule Gnosis merge

@dapplion dapplion requested a review from a team as a code owner November 23, 2022 11:55
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: ff6eab3 Previous: - Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.6606 ms/op
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 85.788 us/op
BLS verify - blst-native 1.8598 ms/op
BLS verifyMultipleSignatures 3 - blst-native 3.8080 ms/op
BLS verifyMultipleSignatures 8 - blst-native 8.1885 ms/op
BLS verifyMultipleSignatures 32 - blst-native 29.688 ms/op
BLS aggregatePubkeys 32 - blst-native 39.202 us/op
BLS aggregatePubkeys 128 - blst-native 153.00 us/op
getAttestationsForBlock 99.657 ms/op
isKnown best case - 1 super set check 429.00 ns/op
isKnown normal case - 2 super set checks 417.00 ns/op
isKnown worse case - 16 super set checks 417.00 ns/op
CheckpointStateCache - add get delete 9.3190 us/op
validate gossip signedAggregateAndProof - struct 4.2571 ms/op
validate gossip attestation - struct 2.0271 ms/op
pickEth1Vote - no votes 2.1293 ms/op
pickEth1Vote - max votes 24.130 ms/op
pickEth1Vote - Eth1Data hashTreeRoot value x2048 12.027 ms/op
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.755 ms/op
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6020 ms/op
pickEth1Vote - Eth1Data fastSerialize tree x2048 16.556 ms/op
bytes32 toHexString 1.2100 us/op
bytes32 Buffer.toString(hex) 749.00 ns/op
bytes32 Buffer.toString(hex) from Uint8Array 1000.0 ns/op
bytes32 Buffer.toString(hex) + 0x 732.00 ns/op
Object access 1 prop 0.39800 ns/op
Map access 1 prop 0.28800 ns/op
Object get x1000 17.440 ns/op
Map get x1000 0.96700 ns/op
Object set x1000 129.80 ns/op
Map set x1000 79.715 ns/op
Return object 10000 times 0.37890 ns/op
Throw Error 10000 times 5.9433 us/op
fastMsgIdFn sha256 / 200 bytes 4.2530 us/op
fastMsgIdFn h32 xxhash / 200 bytes 576.00 ns/op
fastMsgIdFn h64 xxhash / 200 bytes 801.00 ns/op
fastMsgIdFn sha256 / 1000 bytes 13.283 us/op
fastMsgIdFn h32 xxhash / 1000 bytes 717.00 ns/op
fastMsgIdFn h64 xxhash / 1000 bytes 884.00 ns/op
fastMsgIdFn sha256 / 10000 bytes 113.48 us/op
fastMsgIdFn h32 xxhash / 10000 bytes 2.4050 us/op
fastMsgIdFn h64 xxhash / 10000 bytes 1.7490 us/op
enrSubnets - fastDeserialize 64 bits 3.1080 us/op
enrSubnets - ssz BitVector 64 bits 811.00 ns/op
enrSubnets - fastDeserialize 4 bits 426.00 ns/op
enrSubnets - ssz BitVector 4 bits 811.00 ns/op
prioritizePeers score -10:0 att 32-0.1 sync 2-0 103.42 us/op
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 123.80 us/op
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 234.33 us/op
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 494.02 us/op
prioritizePeers score 0:0 att 64-1 sync 4-1 460.42 us/op
RateTracker 1000000 limit, 1 obj count per request 199.67 ns/op
RateTracker 1000000 limit, 2 obj count per request 151.41 ns/op
RateTracker 1000000 limit, 4 obj count per request 127.95 ns/op
RateTracker 1000000 limit, 8 obj count per request 118.24 ns/op
RateTracker with prune 5.2700 us/op
array of 16000 items push then shift 2.7483 us/op
LinkedList of 16000 items push then shift 19.176 ns/op
array of 16000 items push then pop 263.49 ns/op
LinkedList of 16000 items push then pop 17.295 ns/op
array of 24000 items push then shift 3.9796 us/op
LinkedList of 24000 items push then shift 24.161 ns/op
array of 24000 items push then pop 217.63 ns/op
LinkedList of 24000 items push then pop 19.972 ns/op
intersect bitArray bitLen 8 11.735 ns/op
intersect array and set length 8 187.57 ns/op
intersect bitArray bitLen 128 62.081 ns/op
intersect array and set length 128 2.4209 us/op
Buffer.concat 32 items 1.9700 ns/op
pass gossip attestations to forkchoice per slot 4.0575 ms/op
computeDeltas 6.0830 ms/op
computeProposerBoostScoreFromBalances 921.40 us/op
altair processAttestation - 250000 vs - 7PWei normalcase 4.4907 ms/op
altair processAttestation - 250000 vs - 7PWei worstcase 7.1894 ms/op
altair processAttestation - setStatus - 1/6 committees join 219.30 us/op
altair processAttestation - setStatus - 1/3 committees join 417.31 us/op
altair processAttestation - setStatus - 1/2 committees join 585.41 us/op
altair processAttestation - setStatus - 2/3 committees join 753.45 us/op
altair processAttestation - setStatus - 4/5 committees join 1.0455 ms/op
altair processAttestation - setStatus - 100% committees join 1.2306 ms/op
altair processBlock - 250000 vs - 7PWei normalcase 29.629 ms/op
altair processBlock - 250000 vs - 7PWei normalcase hashState 44.353 ms/op
altair processBlock - 250000 vs - 7PWei worstcase 84.945 ms/op
altair processBlock - 250000 vs - 7PWei worstcase hashState 109.86 ms/op
phase0 processBlock - 250000 vs - 7PWei normalcase 4.0314 ms/op
phase0 processBlock - 250000 vs - 7PWei worstcase 48.764 ms/op
altair processEth1Data - 250000 vs - 7PWei normalcase 959.78 us/op
Tree 40 250000 create 1.0533 s/op
Tree 40 250000 get(125000) 300.78 ns/op
Tree 40 250000 set(125000) 3.4496 us/op
Tree 40 250000 toArray() 35.348 ms/op
Tree 40 250000 iterate all - toArray() + loop 35.626 ms/op
Tree 40 250000 iterate all - get(i) 118.92 ms/op
MutableVector 250000 create 20.678 ms/op
MutableVector 250000 get(125000) 13.057 ns/op
MutableVector 250000 set(125000) 810.36 ns/op
MutableVector 250000 toArray() 8.0709 ms/op
MutableVector 250000 iterate all - toArray() + loop 8.2592 ms/op
MutableVector 250000 iterate all - get(i) 3.3023 ms/op
Array 250000 create 7.4984 ms/op
Array 250000 clone - spread 4.1704 ms/op
Array 250000 get(125000) 1.9520 ns/op
Array 250000 set(125000) 1.7320 ns/op
Array 250000 iterate all - loop 167.82 us/op
effectiveBalanceIncrements clone Uint8Array 300000 111.23 us/op
effectiveBalanceIncrements clone MutableVector 300000 1.3780 us/op
effectiveBalanceIncrements rw all Uint8Array 300000 252.51 us/op
effectiveBalanceIncrements rw all MutableVector 300000 290.51 ms/op
phase0 afterProcessEpoch - 250000 vs - 7PWei 187.23 ms/op
phase0 beforeProcessEpoch - 250000 vs - 7PWei 114.69 ms/op
altair processEpoch - mainnet_e81889 605.30 ms/op
mainnet_e81889 - altair beforeProcessEpoch 172.38 ms/op
mainnet_e81889 - altair processJustificationAndFinalization 23.354 us/op
mainnet_e81889 - altair processInactivityUpdates 11.601 ms/op
mainnet_e81889 - altair processRewardsAndPenalties 148.88 ms/op
mainnet_e81889 - altair processRegistryUpdates 4.5960 us/op
mainnet_e81889 - altair processSlashings 1.1650 us/op
mainnet_e81889 - altair processEth1DataReset 1.2600 us/op
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.2483 ms/op
mainnet_e81889 - altair processSlashingsReset 7.8070 us/op
mainnet_e81889 - altair processRandaoMixesReset 7.4070 us/op
mainnet_e81889 - altair processHistoricalRootsUpdate 1.2350 us/op
mainnet_e81889 - altair processParticipationFlagUpdates 3.6700 us/op
mainnet_e81889 - altair processSyncCommitteeUpdates 1.5920 us/op
mainnet_e81889 - altair afterProcessEpoch 199.23 ms/op
phase0 processEpoch - mainnet_e58758 559.60 ms/op
mainnet_e58758 - phase0 beforeProcessEpoch 256.74 ms/op
mainnet_e58758 - phase0 processJustificationAndFinalization 22.070 us/op
mainnet_e58758 - phase0 processRewardsAndPenalties 144.34 ms/op
mainnet_e58758 - phase0 processRegistryUpdates 11.639 us/op
mainnet_e58758 - phase0 processSlashings 917.00 ns/op
mainnet_e58758 - phase0 processEth1DataReset 885.00 ns/op
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.8578 ms/op
mainnet_e58758 - phase0 processSlashingsReset 7.1120 us/op
mainnet_e58758 - phase0 processRandaoMixesReset 7.8920 us/op
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.0270 us/op
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.8320 us/op
mainnet_e58758 - phase0 afterProcessEpoch 160.52 ms/op
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.6241 ms/op
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.5284 ms/op
altair processInactivityUpdates - 250000 normalcase 42.083 ms/op
altair processInactivityUpdates - 250000 worstcase 51.461 ms/op
phase0 processRegistryUpdates - 250000 normalcase 9.3650 us/op
phase0 processRegistryUpdates - 250000 badcase_full_deposits 444.28 us/op
phase0 processRegistryUpdates - 250000 worstcase 0.5 234.32 ms/op
altair processRewardsAndPenalties - 250000 normalcase 137.31 ms/op
altair processRewardsAndPenalties - 250000 worstcase 92.154 ms/op
phase0 getAttestationDeltas - 250000 normalcase 15.327 ms/op
phase0 getAttestationDeltas - 250000 worstcase 15.605 ms/op
phase0 processSlashings - 250000 worstcase 5.5341 ms/op
altair processSyncCommitteeUpdates - 250000 302.42 ms/op
BeaconState.hashTreeRoot - No change 524.00 ns/op
BeaconState.hashTreeRoot - 1 full validator 65.491 us/op
BeaconState.hashTreeRoot - 32 full validator 772.00 us/op
BeaconState.hashTreeRoot - 512 full validator 7.5793 ms/op
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 80.598 us/op
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.2180 ms/op
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 16.781 ms/op
BeaconState.hashTreeRoot - 1 balances 59.938 us/op
BeaconState.hashTreeRoot - 32 balances 580.39 us/op
BeaconState.hashTreeRoot - 512 balances 5.9993 ms/op
BeaconState.hashTreeRoot - 250000 balances 96.481 ms/op
aggregationBits - 2048 els - zipIndexesInBitList 37.910 us/op
regular array get 100000 times 67.390 us/op
wrappedArray get 100000 times 67.440 us/op
arrayWithProxy get 100000 times 28.595 ms/op
ssz.Root.equals 521.00 ns/op
byteArrayEquals 503.00 ns/op
shuffle list - 16384 els 11.124 ms/op
shuffle list - 250000 els 163.90 ms/op
processSlot - 1 slots 13.185 us/op
processSlot - 32 slots 1.8526 ms/op
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 408.29 us/op
getCommitteeAssignments - req 1 vs - 250000 vc 5.3373 ms/op
getCommitteeAssignments - req 100 vs - 250000 vc 7.3072 ms/op
getCommitteeAssignments - req 1000 vs - 250000 vc 7.8090 ms/op
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 10.170 ns/op
state getBlockRootAtSlot - 250000 vs - 7PWei 1.2653 us/op
computeProposers - vc 250000 18.061 ms/op
computeEpochShuffling - vc 250000 167.83 ms/op
getNextSyncCommittee - vc 250000 300.27 ms/op

by benchmarkbot/action

@twoeths
Copy link
Contributor

twoeths commented Nov 23, 2022

@dapplion some Browser tests failed

@dapplion dapplion merged commit f093b46 into stable Nov 23, 2022
@dapplion dapplion deleted the rc/v1.2.2 branch November 23, 2022 18:26
@dapplion dapplion changed the title Release v1.2.2 Schedule gnosis merge Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants