chore(dot/core): code substitution uses wasmer only #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8580d4 to
745c03a
Compare
745c03a to
d5ae2f6
Compare
- Remove `wasmerInstanceFunc` function type - Add error wrapping context within `handleCodeSubstitution` - Adding sentinel errors for wasm decompression - Fix and improve `Test_Service_handleCodeSubstitution` - Add runtime instance gomock mock
d5ae2f6 to
9979cd8
Compare
noot
approved these changes
Aug 5, 2022
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
💁 most additions are just the generated mock and fixed/changed unit test
Blocking me on my trie metrics branch due to some nifty interface problem (function signature must use the same interface, which I'm not happy with).
wasmerInstanceFuncfunction typehandleCodeSubstitutionTest_Service_handleCodeSubstitutionTests
go test -run ^Test_Service_handleCodeSubstitution$ github.com/ChainSafe/gossamer/dot/coreIssues
Related to #2229
Primary Reviewer
@kishansagathiya