chore(lib/trie): refactor database tests #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7606da9 to
4e9997d
Compare
9e81d43 to
689751f
Compare
f08d09d to
d43e9af
Compare
f33420d to
c3dc9ab
Compare
d43e9af to
ae15202
Compare
Codecov Report
@@ Coverage Diff @@
## development #2338 +/- ##
===============================================
- Coverage 61.52% 61.52% -0.01%
===============================================
Files 215 215
Lines 28267 28267
===============================================
- Hits 17391 17390 -1
+ Misses 9105 9104 -1
- Partials 1771 1773 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
39ab29e to
24bb458
Compare
ae15202 to
3eebd91
Compare
Base automatically changed from
qdm12-trie-branch-descendants
to
qdm12-trie-copy-less
March 14, 2022 19:10
80998f2 to
917e1c2
Compare
3eebd91 to
0091757
Compare
e0eee15 to
ba3c5dd
Compare
0091757 to
bafc15f
Compare
ba3c5dd to
908596a
Compare
908596a to
4b32aaf
Compare
bafc15f to
19d419b
Compare
|
I changed the refactor further to use randomly generated key values. This helped me out find a bug in another branch, so it definitely has a use. Unfortunately, I don't think fuzzing can be applied in this particular case. |
EclesioMeloJunior
approved these changes
Apr 27, 2022
- Bigger test sets (can't use fuzzing) - Removed hardcoded test sets - Removed duplicate tests - Rename `res` tries to `trieFromDB` - Remove unneeded test code for loops
19d419b to
613dffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
run with subtests(older)extensible test case struct fields(older)Store repeating values in functions(older)restries totrieFromDBℹ️ New changes were made to have bigger random test sets since this helped me out debunk some problems in another branch
Tests
Issues
Primary Reviewer