chore(lib/trie): refactor ClearPrefixLimit

[qdm12]

Changes

• Pass limit and return values deleted count, do not pass limit as pointer downstream
• Simpler code more appropriate for end goal (return number of deleted values)
• Helps Instrument the trie with Prometheus metrics #2229

Tests

go test ./internal/trie/... ./lib/trie/...

Issues

• Instrument the trie with Prometheus metrics #2229

Primary Reviewer

[codecov]

Codecov Report

Merging #2298 (dbcff38) into development (625cbcf) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development    #2298   +/-   ##
============================================
  Coverage        57.55%   57.55%           
============================================
  Files              212      212           
  Lines            27952    27952           
============================================
  Hits             16089    16089           
- Misses           10228    10229    +1     
+ Partials          1635     1634    -1     

Flag	Coverage Δ
unit-tests	57.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/trie/trie.go	99.33% <100.00%> (+1.20%)	⬆️
dot/network/message.go	66.52% <0.00%> (-2.61%)	⬇️
dot/network/host.go	64.31% <0.00%> (-1.07%)	⬇️
dot/network/light.go	85.25% <0.00%> (-0.80%)	⬇️
dot/network/service.go	55.88% <0.00%> (+0.45%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625cbcf...dbcff38. Read the comment docs.