chore(lib/blocktree): replace sync.Map with mutex protected map
#2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2285 +/- ##
===============================================
+ Coverage 57.58% 57.63% +0.04%
===============================================
Files 211 212 +1
Lines 27906 27922 +16
===============================================
+ Hits 16070 16092 +22
+ Misses 10207 10199 -8
- Partials 1629 1631 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sync.Map with map+mutexsync.Map with mutex protected map
abaff34 to
61fdb65
Compare
noot
reviewed
Feb 16, 2022
lib/blocktree/hashtoinstance.go
Outdated
| "github.com/ChainSafe/gossamer/lib/runtime" | ||
| ) | ||
|
|
||
| type hashToInstance struct { |
There was a problem hiding this comment.
Suggested change
| type hashToInstance struct { | |
| type hashToRuntimeInstance struct { |
There was a problem hiding this comment.
Renaming it to hashToRuntime it makes more sense I think (and also is shorter)
noot
approved these changes
Feb 16, 2022
61fdb65 to
56826d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
runtime.Instanceruntime->runtimesinBlockTreesince it's a mapping from hash to runtime instance, not just a single runtimeTests
Issues
sync.Map#2281Primary Reviewer