Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge approvals on multisig removal #967

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Purge approvals on multisig removal #967

merged 2 commits into from
Jan 26, 2021

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Purging removals was not updated (or added in the first place, not sure when/if this was changed)
  • Logic deleted in execute_transaction_if_approved does not functionally change anything, just somehow was missed in v2 update and didn't affect anything

Fixes state diff at height 435908

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell added Type: Bug Something isn't working Status: Needs Review labels Jan 26, 2021
@austinabell austinabell merged commit 3b16f80 into main Jan 26, 2021
@austinabell austinabell deleted the austin/fix/msigrem branch January 26, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ec2 ec2 ec2 approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@austinabell @ec2