-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage miner integration #670
Conversation
Gunna go much more in depth tomorrow. My cloud lotus node is currently syncing.
|
I would use the same commands :) |
You committed the grpc protobuf submodule by the way (and I assume unintended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still do believe that only the variables that need to be mutated across threads in the chain store should be wrapped in a mutex, you are adding locks around a lot of logic that doesn't need it and performance and/or deadlocks might be a problem
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
Co-authored-by: Austin Abell <austinabell8@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending @ec2's checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot the hit approve lgtm
Co-authored-by: Austin Abell <austinabell8@gmail.com>
…Safe/forest into storage-miner-intergration
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #629
Closes #630
Closes #631
Closes #632
Other information and links