Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix StateMinerSectors tests #5154

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 17, 2025

Summary of changes

Changes introduced in this pull request:

  • added option to accept test results where the second endpoint times out, which might happen with Lotus. Increasing the timeout in our CI would lead to longer workflow durations and bizarre GHA outputs, see fix: increase RPC request timeout in API compare tests #5129
  • ignore success-timeout occurrences in the regular API compare run
  • reduce --n-tipsets to 5 to reduce RPC check duration a bit

Reference issue to close (if applicable)

Closes #4718
Closes #5100

Other information and links

      --test-criteria-overrides [<TEST_CRITERIA_OVERRIDES>...]
          Additional overrides to modify success criteria for tests

          [default: TimeoutAndTimeout]

          Possible values:
          - valid-and-timeout:   Test pass when first endpoint returns a valid result and the second one timeout
          - timeout-and-timeout: Test pass when both endpoints timeout

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the fix-state-miner-sectors-rpc branch from 6d926fb to 17e0230 Compare January 17, 2025 13:36
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review January 20, 2025 11:45
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 20, 2025 11:46
@LesnyRumcajs LesnyRumcajs requested review from lemmih and sudo-shashank and removed request for a team January 20, 2025 11:46
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit c899a6d Jan 20, 2025
48 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-state-miner-sectors-rpc branch January 20, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filecoin.StateMinerSectors is flaky Revive tests with old beacons
3 participants